Enhance support for Vasco and ClimaRad HRUs

[silverailscolo]

Proposed additions to process messages from a Vasco D60 HRU (2022), a ClimaRad VenturaV1x HRU (2021) and a ClimaRad MiniBox fan that I have installed in my home.

I have ramses_rf communicating via ramses_esp on an ESP32S3 board with a C1101..

Not all commands as entered in the ramses-rf CLI cause a change on the units, but at least reporting from the units works. The message contents are not shared by the manufacturer and especially for the Ventura they customized them. The PCBs are all Airios OEM.
Many messages from the units and their remotes are rejected by ramses-rf, so I cannot run Home Assistant with ramses-cc at the moment.

Hope to have made it a bit easier to add suport for these models in ramses-rf. The typed stuff is a bit too much so I cheated somewhat there. Fixed some typos in comments across your module while browsing.
Added a packet log below. I can provide more info upon request.

Cheers, Egbert

packet3.log

[zxdavb]

Thanks for your contribution, I am looking forward to merging it in.

You'll see that the PR did not pass CI, are you running the pre-commit, mypy and pytest?

pre-commit run -a
mypy
pytest

... all these should pass before submitting a PR.

Second, the PR should be as small as possible, and atomic. If something could be split off as a separate PR, generally it should be: the spelling typos are once such example.

[zxdavb]

OMG, just adding codespell - is full of typos - I will add codespell, fix many of these in my own PR.

(you'll have to rebase)

[zxdavb]

This is a first step. We can look again, once I have time to understand the detail.

[zxdavb]

You need to add some test bindings of these systems. Look at ./tests/bindings/hvac/*

[silverailscolo]

Bindings are further down the To Do list. Have to climb on top of our bathroom to push a button on the MiniBox...
Took these lines out of the 22F1 PR #136 .

[silverailscolo]

Thanks for the educational pointers.
Running mypy (latest v 1.11.2) - as well as my IDE (IntelliJ) - on current HEAD master already gives 27 errors like:

src/ramses_cli/client.py:449: error: "Code" has no attribute "values"  [attr-defined]

On my PR branch I get 8 more, but still.

As a novice in mypy I wonder if you happen to know a fix/setting? It it a version thing perhaps (python 3.12 here).

[zxdavb]

Running mypy (latest v 1.11.2) - as well as my IDE (IntelliJ) - on current HEAD master already gives 27 errors like:

I can reproduce this... the solution is to pip install -e . like so:

python3 -m venv venv
source venv/bin/activate
pip install -e .
pip install -r requirements_dev.txt

It is not immediately clear to me why the existing pyproject.toml isn't sorting it out without the -e.

[zxdavb]

OK, I have had a deeper look now, and here's a way forward...

It appears you have updated the parsers for at least the following command codes:

• 12A0, 2210, 22F1, 22F3, 22F4, 31DA & 3200

I am going to ask you to submit multiple PRs - one for each code.

You will also need to add packets to the corresponding tests. For example, look at:

• tests/tests/parsers/code_22f1.log

In addition, it will be very helpful if you have a log of your remotes/sensors binding to your fans. This will help with faking.

And also a 10E0 packet for all of your devices that emit one.

• tests/tests/parsers/code_10e0.log

[silverailscolo]

It is not immediately clear to me why the existing pyproject.toml isn't sorting it out without the -e.

For my own reference, learned this on Stackoverflow:

To execute a local package containing absolute or relative imports without needing to install it. This use case is detailed in PEP 338 and leverages the fact that the current working directory is added to sys.path rather than the module's directory. This use case is very similar to using pip install -e. to install a package in develop/edit mode.

Sorting out my Python setup now.

[silverailscolo]

submit multiple PRs - one for each code.

Perfect approach, thanks. TBC

[silverailscolo]

Current TO DO

• 0002 (Ventura) Tweak 0002 for ClimaRad #153
• 10E0 (All 6) OEM names + signatures Tweak 10E0 for Vasco/ClimaRad HVAC #134
• 10D0 Tweak 10D0 parser for Vasco HVAC #140
• 1298 Tweak 1298 for Vasco HVAC #137
• 12A0 (Ventura) Tweak 12A0 for ClimaRad HVAC #142
• 042F WIP Tweak 042F parser for Vasco HVAC #135
• 2210 (Ventura) Tweak 2210 for ClimaRad #151
• 22E9 (D60) Tweak 22E9 for Vasco D60 #145 annotate packet log changes
• 22F1 (fans) Tweak 22F1 for Vasco REM/CO2 #136
• 22F2 Tweak 22F2 for Vasco D60 #144 + extra packet Add 22F2 packet for ClimaRad MiniBox to parser tests #154
• 22F3 (fans) Tweak 22F3 for Vasco/ClimaRad HVAC #138
• 22F4 Tweak 22F4 parser, based upon ClimaRad #150
• 2E10 (Ventura + fans) Tweak 2E10 for ClimaRad HVAC #139
• 3150 Tweak 3150 for ClimaRad Ventura V1X #141
• 31D9 (Ventura, D60) Tweak 31D9 for ClimaRad HVAC #152
• 31DA (Ventura) Tweak 31DA for ClimaRad #148
• 3200 Tweak 3200 for ClimaRad #155
• 3222 Tweak 3222 for Vasco D60 #146
• 1FC9 Add 1FC9 bind packets for Vasco and Climarad fans #158 + Vasco Add 1FC9 binding logs for Vasco and ClimaRad #159
• 1FC9 ClimaRad MiniBox Add 1FC9 binding logs for Vasco and ClimaRad #159
• 1FC9 ClimaRad Ventura Add 1FC9 binding logs for Vasco and ClimaRad #159

[zxdavb]

You can leave this PR here for now - the TODO list is useful.

As I said in #134 - start with the codes, one PR per code - a number of smaller PRs is much easier to get merged (for both of us).

You don't have to do one at a time, you can have several codes on the go at once, but start with a simple one, and you know what to expect to get your PR merged (e.g. including your new payloads in the test suite).

[silverailscolo]

All open PR's in the above list are now ready for your review

[silverailscolo]

Current master reports these codes as errors still:

• 12A0 Payload doesn't match
• 2210 report this packet RP 2-4x/minute
• 2E10 report this packet
• still watching...

[silverailscolo]

@zxdavb Any chance we can see these changes in a ramses_cc update before year's end?

[zxdavb]

I am sorry, but it looks unlikely I'll have that much time.

What is the feature you're wanting most?

[silverailscolo]

That would be 10E0, 1298 and 22F1 for a start.