Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak 10D0 parser for Vasco HVAC #140

Merged
merged 5 commits into from
Oct 17, 2024
Merged

Conversation

silverailscolo
Copy link
Contributor

@silverailscolo silverailscolo commented Oct 14, 2024

No new logs for 10D0. Checks passed

@zxdavb
Copy link
Owner

zxdavb commented Oct 15, 2024

Do you have any 10D0 packets in a packet log to support your PR? I would expect to see them.

If so, they need to be added to tests/tests/parsers/code_10d0.log? They will, if they are different to the existing W|10D0|00FF packet:

2022-07-03T22:52:34.571579 045  W --- 37:171871 32:155617 --:------ 10D0 002 00FF          # {'reset_counter': True}

@silverailscolo
Copy link
Contributor Author

They will, if they are different to the existing W|10D0|00FF packet:

They are identical, so I didn't add a copy

@silverailscolo
Copy link
Contributor Author

I received a new packet Filter Change Reply from the D60 after placing the ramses_esp nearby:

2024-10-15 12:33:55.595000 000 RQ --- 18:130140 32:022222 --:------ 10D0 001 00            # {}
2024-10-15 12:33:55.609000 --- RP --- 32:022222 18:130140 --:------ 10D0 006 00A9B6B90000  # {'days_remaining': 185}

Added to the 10D0 tests file.

src/ramses_tx/parsers.py Outdated Show resolved Hide resolved
src/ramses_tx/parsers.py Show resolved Hide resolved
Co-authored-by: David Bonnes <[email protected]>
src/ramses_tx/parsers.py Show resolved Hide resolved
tests/tests/parsers/code_10d0.log Outdated Show resolved Hide resolved
@silverailscolo silverailscolo changed the title 10D0 Parser 10D0 parser Oct 16, 2024
@zxdavb zxdavb changed the title 10D0 parser Tweak 10D0 parser for Vasco HVAC Oct 17, 2024
@zxdavb zxdavb merged commit 36d0934 into zxdavb:master Oct 17, 2024
5 checks passed
@zxdavb
Copy link
Owner

zxdavb commented Oct 17, 2024

Thanks @silverailscolo

@zxdavb zxdavb changed the title Tweak 10D0 parser for Vasco HVAC Tweak 10D0 parser for Vasco HVAC Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants