Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak 10E0 for Vasco/ClimaRad HVAC #134

Merged
merged 13 commits into from
Nov 10, 2024
Merged

Tweak 10E0 for Vasco/ClimaRad HVAC #134

merged 13 commits into from
Nov 10, 2024
+46 −8

Conversation

silverailscolo
Copy link
Contributor

@silverailscolo silverailscolo commented Oct 13, 2024 •
edited by zxdavb
Loading

This PR adds signature information for the following hardware:

Vasco

  • 32:022222 HRU D60 (VMD-17RPS01) legacy product, no docs on Vasco site
  • 37:117647 CO2 Sensor / Remote (VMS-17C01) docs
  • 29:091138 REM 4-button RF Remote (VMN-17LMP01) docs

Vasco D60 brochure NL.pdf

ClimaRad

  • 29:099029 FAN MiniBox (VMC-07RP01) docs
  • 37:153226 HRU Ventura V1x (VMD-07RPS13) docs
  • 29:123150 REM 4-button RF Remote (VMN-07LM01) docs

@silverailscolo silverailscolo mentioned this pull request Oct 13, 2024
Open
@zxdavb
Copy link
Owner

zxdavb commented Oct 13, 2024

I recommend you put this PR on hold, and do 22F1 first.

Experience tells me that will be the easiest way forward.

zxdavb
zxdavb requested changes Oct 13, 2024
View reviewed changes
src/ramses_tx/parsers.py Outdated Show resolved Hide resolved
src/ramses_tx/fingerprints.py Outdated Show resolved Hide resolved
src/ramses_tx/schemas.py Outdated Show resolved Hide resolved
src/ramses_tx/parsers.py Outdated Show resolved Hide resolved
@silverailscolo silverailscolo changed the title Vasco/ClimaRad general additions WIP Vasco/ClimaRad general additions Oct 14, 2024
@silverailscolo silverailscolo changed the title WIP Vasco/ClimaRad general additions 10e0 Oct 15, 2024
@silverailscolo silverailscolo changed the title 10e0 10E0 Parser Oct 15, 2024
@zxdavb
Copy link
Owner

zxdavb commented Oct 16, 2024

If you could list the make/model of the devices that your adding 10E0 packets for? A link to a URL of that product would be useful too.

zxdavb
zxdavb requested changes Oct 16, 2024
View reviewed changes
tests/tests/parsers/code_10e0.log Show resolved Hide resolved
tests/tests/parsers/code_10e0.log Show resolved Hide resolved
tests/tests/parsers/code_10e0.log Show resolved Hide resolved
@silverailscolo
Copy link
Contributor Author

silverailscolo commented Oct 16, 2024 •
edited by zxdavb
Loading

If you could list the make/model of the devices that your adding 10E0 packets for? A link to a URL of that product would be useful too.

Where would you want this information to be stored? Don't see any urls in the 10E0 or fingerprints/hvac yet

@silverailscolo silverailscolo changed the title 10E0 Parser 10E0 parser Oct 16, 2024
@zxdavb zxdavb changed the title 10E0 parser Tweak 10E0 for Vasco/ClimaRad Oct 17, 2024
@zxdavb zxdavb changed the title Tweak 10E0 for Vasco/ClimaRad Tweak 10E0 for Vasco/ClimaRad HVAC Oct 17, 2024
@zxdavb
Copy link
Owner

zxdavb commented Oct 17, 2024

Where would you want this information to be stored?

See first post, which I have edited.

zxdavb
zxdavb requested changes Oct 17, 2024
View reviewed changes
tests/tests/fingerprints/hvac/37_VMD-17RPS13.log Outdated Show resolved Hide resolved
tests/tests/fingerprints/hvac/29_VMN-17LMP01.log Outdated Show resolved Hide resolved
@zxdavb zxdavb merged commit e469e09 into zxdavb:master Nov 10, 2024
5 checks passed
@zxdavb
Copy link
Owner

zxdavb commented Nov 10, 2024

Nice one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zxdavb zxdavb Awaiting requested review from zxdavb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@silverailscolo @zxdavb