-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vertex/edge cutting #216
Vertex/edge cutting #216
Conversation
Added a small function to return the averaged position between two points (just basic trig)
Added functions to apply the basic vertex and edge cutting decompositions
Can you please add tests? |
Added tests for vertex and edge cutting on random graphs to verify the scalar results are correct
I've just added some tests for both functions to verify the scalar results are correct on randomly generated graphs |
Could you add docstrings to the main functions you added, with perhaps a reference to your papers where you use them. |
pyzx/simulate.py:500: error: invalid syntax [syntax] |
Ah I see what goes wrong. You are using match statements, but these were introduced in Python 3.10. PyZX still supports older versions of Python. I see that in that match statement you are also using hard-coded |
Add new 'wishbone' (or 'separator') cutting variant for unfusing a vertex and cutting this new common edge (in the same colour as the original vertex) - this acts to separate a vertex into two, via one cut, with some neighbours on one side and some on another.
Can this be merged? |
Yes, this should be all good 👍 |
Included functions for applying the vertex and edge cutting decompositions