Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing row height when cloning the original table #21

Closed
wants to merge 8 commits into from
+14 −17
Closed

Fixing row height when cloning the original table #21

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e2ebfd0
Fixing table row heights when cloning. Fixes #15
Aug 9, 2013
c55b491
Merge branch 'feature-samerowheight'
Aug 9, 2013
a280483
Changed to .height instead of .outerHeight due to sizing issues when …
Aug 9, 2013
c7bc34f
Merge branch 'feature-samerowheight'
Aug 9, 2013
7c8ab36
Found a better height solution that doesn't break the table layout wh…
Aug 9, 2013
e0dc5bf
Merge branch 'feature-samerowheight'
Aug 9, 2013
1fcdb95
Making sure the height is set so all records show (prevents row cutoff)
Aug 9, 2013
ae605c7
Merge branch 'feature-samerowheight'
Aug 9, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 14 additions & 17 deletions responsive-tables.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ $(document).ready(function() {
original.wrap("<div class='scrollable' />");

setCellHeights(original, copy);
setTableHeights(original, copy);
}

function unsplitTable(original) {
Expand All @@ -43,25 +44,21 @@ $(document).ready(function() {
}

function setCellHeights(original, copy) {
var tr = original.find('tr'),
tr_copy = copy.find('tr'),
heights = [];

tr.each(function (index) {
var self = $(this),
tx = self.find('th, td');

tx.each(function () {
var height = $(this).outerHeight(true);
heights[index] = heights[index] || 0;
if (height > heights[index]) heights[index] = height;
});

$('tr', original).each(function(index){
oheight = $(this).height();
cheight = $('tr:eq('+index+')', copy).height();
height = (oheight > cheight ? oheight : cheight);
$('th,td', original).css('height', height+'px');
$('th,td', copy).css('height', height+'px');
});
}

tr_copy.each(function (index) {
$(this).height(heights[index]);
});
function setTableHeights(original, copy) {
oheight = original.outerHeight();
cheight = copy.outerHeight();
height = (oheight > cheight ? oheight : cheight);
original.css('min-height', height+'px');
copy.css('min-height', height+'px');
}

});