Fixing row height when cloning the original table #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
August 9, 2013 08:46
|
Brilliant, thanks! This fixed my pinned table height mismatch problems. |
|
This patch is fantastic @seriouslysean. Thank-you. Looks like nobody is maintaining this project though. |
NicholasRBowers
added a commit
to NicholasRBowers/responsive-tables
that referenced
this pull request
Apr 15, 2015
Fixes issues: - zurb#15 - zurb#18 - zurb#21 NOTE: I could not pull the PR manually, as the the changes were from an "unknown repository". Credit for this commit should go to https://github.com/seriouslysean.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling$(this).height(height[index]) doesn't do anything as height() doesn't accept any arguments. I switched it to $ (this).css('height', heights[index]+'px'); for the original and the copy so that both rows match in height when the pinning takes place.