Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS Security Group changes #101

Merged
merged 5 commits into from
Sep 24, 2024
Merged

AWS Security Group changes #101

merged 5 commits into from
Sep 24, 2024

Conversation

jmolnar-zscaler
Copy link
Collaborator

ENHANCEMENTS:

  • Module Changes:
    • terraform-zscc-ccvm-aws:
      • add variable additional_management_security_group_ids
    • terraform-zscc-asg-aws:
      • add variable additional_management_security_group_ids
    • terraform-zscc-sg-aws:
      • add resource aws_security_group.outbound_endpoint_sg
      • add variables byo_route53_resolver_outbound_endpoint_group_id and zpa_enabled
    • terraform-zscc-route53-aws:
      • add variable outbound_endpoint_security_group_ids
      • remove default security group usage per AWS best practices

Copy link
Collaborator

@nmizhquirizs nmizhquirizs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Looks good. Please fix the Merge Conflicts on the CHANGELOG.md

@jmolnar-zscaler jmolnar-zscaler merged commit 1fabb46 into develop Sep 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants