Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Route53 resolver endpoint security group AWS best practices, or allow BYO security group for the outbound endpoints #84

Conversation

veqryn
Copy link
Contributor

@veqryn veqryn commented Jun 20, 2024

Currently, the Route53 module uses the "default" security group.
Many companies have locked down the default security group. In our AWS environment, we have deleted all the inbound and outbound rules on the default security group (intentionally, to force each application to use a security group specific to it).

Additionally, the default security group does not follow AWS Best Practices for Route53 Outbound Endpoints.
https://docs.aws.amazon.com/Route53/latest/DeveloperGuide/best-practices-resolver-endpoint-scaling.html

This PR stops using the default security group, and creates a security group that follows the aws best practices.
It also allows a bring your own security group for the endpoint.
Existing formats were followed.

@veqryn
Copy link
Contributor Author

veqryn commented Sep 24, 2024

Hi @jmolnar-zscaler , can I ask why this one was closed? We require it for zpa to work in our environment.

@jmolnar-zscaler
Copy link
Collaborator

apologies for lack of response. I took these commit proposals and are running them through validation for our next release as well. #101

@veqryn
Copy link
Contributor Author

veqryn commented Sep 25, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants