Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue4083 change prefix meaning #4097

Merged
merged 5 commits into from
Dec 2, 2024
Merged

issue4083 change prefix meaning #4097

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
de92787
issue4083 change prefix meaning
pavelzlatnik Nov 22, 2024
417179d
update based on feedback
pavelzlatnik Nov 27, 2024
9820462
update based on Mark's feedback
pavelzlatnik Nov 28, 2024
7cc06a9
Merge branch 'v3.x/staging' into user/zlatnikp/changepfxtarget
MarkAckert Dec 2, 2024
90dcf2b
Merge branch 'v3.x/staging' into user/zlatnikp/changepfxtarget
MarkAckert Dec 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion example-zowe.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ zowe:
# MVS data set related configurations
dataset:
# **COMMONLY_CUSTOMIZED**
# where Zowe MVS data sets will be installed
# HLQ where are existing Zowe SZWEEXEC Target libraries
prefix: IBMUSER.ZWEV3
# **COMMONLY_CUSTOMIZED**
# PROCLIB where Zowe STCs will be copied over
Expand Down
8 changes: 4 additions & 4 deletions workflows/files/ZWECONF.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,9 @@
</workflowInfo>
<!--variables-->
<variable name="zowe_setup_dataset_prefix" scope="instance" visibility="public">
<label>Zowe setup MVS prefix</label>
<abstract>Where Zowe MVS data sets will be installed</abstract>
<description>Where Zowe MVS data sets will be installed</description>
<label>Prefix of existing Zowe SZWEEXEC Target libraries</label>
<abstract>Prefix (HLQ) of existing SZWEEXEC Target libraries created during PSWI or SMP/E</abstract>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should remove HLQ from these descriptions and retain Prefix. HLQ has special meaning as the first 8-character qualifier of a dataset, while prefix can include multiple qualifiers.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree

<description>Prefix (HLQ) of existing SZWEEXEC Target libraries created during PSWI or SMP/E installation phase</description>
<category>zowe</category>
<string valueMustBeChoice="false" multiLine="false">
<!-- Put validation here -->
Expand Down Expand Up @@ -1475,7 +1475,7 @@ echo ' setup:' >> "${instance-zowe_runtimeDirectory}/zowe.yaml"
echo ' # MVS data set related configurations' >> "${instance-zowe_runtimeDirectory}/zowe.yaml"
echo ' dataset:' >> "${instance-zowe_runtimeDirectory}/zowe.yaml"
echo ' # **COMMONLY_CUSTOMIZED**' >> "${instance-zowe_runtimeDirectory}/zowe.yaml"
echo ' # where Zowe MVS data sets will be installed' >> "${instance-zowe_runtimeDirectory}/zowe.yaml"
echo ' # HLQ where are existing Zowe SZWEEXEC Target libraries' >> "${instance-zowe_runtimeDirectory}/zowe.yaml"
echo ' prefix: $!{instance-zowe_setup_dataset_prefix}' >> "${instance-zowe_runtimeDirectory}/zowe.yaml"
echo ' # **COMMONLY_CUSTOMIZED**' >> "${instance-zowe_runtimeDirectory}/zowe.yaml"
echo ' # PROCLIB where Zowe STCs will be copied over' >> "${instance-zowe_runtimeDirectory}/zowe.yaml"
Expand Down
Loading