Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue4083 change prefix meaning #4097

Merged
merged 5 commits into from
Dec 2, 2024
Merged

issue4083 change prefix meaning #4097

merged 5 commits into from
Dec 2, 2024

Conversation

pavelzlatnik
Copy link
Contributor

  • Tests for the changes have been added (for bug fixes / features)
  • Necessary documentation (if appropriate) have been added / updated
  • DCO signoffs have been added to all commits, including this PR

PR type

What type of changes does your PR introduce to Zowe? Put an x in the box that applies to this PR. If you're unsure about any of them, don't hesitate to ask.

  • Bugfix
  • Feature
  • Other... Please describe:

Relevant issues

Fixes #4083

Changes proposed in this PR

Based on issue description and proposed solutions, changed "PREFIX" variable description in the workflow, and also updated variable description in example.

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR do something the person installing Zowe should know about?

  • Affected function: general area of interest *
  • Description: 1 line description *
  • Part: name of customizable file involved *

multi-line description

Is there a related doc issue or Pull Request?

Doc issue/PR number:

Other information

@pavelzlatnik
issue4083 change prefix meaning
de92787 
Signed-off-by: Pavel Zlatnik <[email protected]>
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 22, 2024 •
edited
Loading

build 6484 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/11974751132

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 22, 2024 •
edited
Loading

Test workflow 5715 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/3.1.0-PR-4097/zowe-3.1.0-pr-4097-6484-20241122145031.pax
Running on machine: zzow09
Result: FAILURE
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/11974848272

muzikovam
muzikovam reviewed Nov 26, 2024
View reviewed changes
workflows/files/ZWECONF.xml Outdated
<description>Where Zowe MVS data sets will be installed</description>
<label>Prefix of existing Zowe Target libraries</label>
<abstract>Prefix of existing Target libraries created during PSWI or SMP/E</abstract>
<description>Prefix of existing Target libraries created during PSWI or SMP/E installation phase</description>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add here that it is HLQ of SZWEEXEC, please.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@pavelzlatnik
update based on feedback
417179d 
Signed-off-by: Pavel Zlatnik <[email protected]>
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 27, 2024 •
edited
Loading

build 6501 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/12046687303

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 27, 2024 •
edited
Loading

Test workflow 5724 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/3.1.0-PR-4097/zowe-3.1.0-pr-4097-6501-20241127084830.pax
Running on machine: zzow10
Result: FAILURE
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/12046762910

MarkAckert
MarkAckert reviewed Nov 27, 2024
View reviewed changes
workflows/files/ZWECONF.xml Outdated
<abstract>Prefix of existing Target libraries created during PSWI or SMP/E</abstract>
<description>Prefix of existing Target libraries created during PSWI or SMP/E installation phase</description>
<label>Prefix of existing Zowe SZWEEXEC Target libraries</label>
<abstract>Prefix (HLQ) of existing SZWEEXEC Target libraries created during PSWI or SMP/E</abstract>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should remove HLQ from these descriptions and retain Prefix. HLQ has special meaning as the first 8-character qualifier of a dataset, while prefix can include multiple qualifiers.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree

@pavelzlatnik
update based on Mark's feedback
9820462 
Signed-off-by: Pavel Zlatnik <[email protected]>
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 28, 2024 •
edited
Loading

build 6510 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/12065613951

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 28, 2024 •
edited
Loading

Test workflow 5731 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/3.1.0-PR-4097/zowe-3.1.0-pr-4097-6510-20241128090434.pax
Running on machine: zzow11
Result: FAILURE
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/12065701049

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 2, 2024 •
edited
Loading

build 6524 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/12126842284

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 2, 2024 •
edited
Loading

Test workflow 5747 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/3.1.0-PR-4097/zowe-3.1.0-pr-4097-6524-20241202195714.pax
Running on machine: zzow09
Result: SUCCESS
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/12126963847

@MarkAckert MarkAckert added the Build: None Used in CI label Dec 2, 2024
@MarkAckert MarkAckert merged commit 6352529 into v3.x/staging Dec 2, 2024
8 checks passed
@MarkAckert MarkAckert deleted the user/zlatnikp/changepfxtarget branch December 2, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkAckert MarkAckert MarkAckert approved these changes

@muzikovam muzikovam muzikovam approved these changes

@dkelosky dkelosky Awaiting requested review from dkelosky

Assignees
No one assigned
Labels
Build: None Used in CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PSWI - z/OSMF Workflows: ZWEV2.SZWEEXEC no created
4 participants
@pavelzlatnik @muzikovam @MarkAckert @zowe-robot