Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Avoid data-loss when creating new members #3392

Merged
merged 7 commits into from
Jan 14, 2025
Merged

fix: Avoid data-loss when creating new members #3392

merged 7 commits into from
Jan 14, 2025

Conversation

zFernand0
Copy link
Member

Proposed changes

Release Notes

Milestone: 3.1.1

Changelog: Prevented data-loss when creating a new member called something that already exists.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds or improves functionality)
  • Breaking change (a change that would cause existing functionality to not work as expected)
  • Documentation (Markdown, README updates)
  • Other (please specify above in "Proposed changes" section)

Checklist

General

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • All PR dependencies have been merged and published (if applicable)
  • A GIF or screenshot is included in the PR for visual changes
  • The pre-publish command has been executed:
    • v2 and below: yarn workspace vscode-extension-for-zowe vscode:prepublish
    • v3: pnpm --filter vscode-extension-for-zowe vscode:prepublish

Code coverage

  • There is coverage for the code that I have added
  • I have added new test cases and they are passing
  • I have manually tested the changes

Deployment

  • I have added developer documentation (if applicable)
  • Documentation should be added to Zowe Docs
    • If you're an outside contributor, please post in the #zowe-doc Slack channel to coordinate documentation.
    • Otherwise, please check with the rest of the squad about any needed documentation before merging.
  • These changes may need ported to the appropriate branches (list here):

Further comments

Signed-off-by: Fernando Rijo Cedeno <[email protected]>
Signed-off-by: Fernando Rijo Cedeno <[email protected]>
@zFernand0 zFernand0 added the needs-ported Apply to issues or PRs that need ported label Jan 13, 2025
Copy link

📅 Suggested merge-by date: 1/27/2025

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.18%. Comparing base (baade3a) to head (ca2d52b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #3392    +/-   ##
========================================
  Coverage   93.18%   93.18%            
========================================
  Files         120      120            
  Lines       12486    12490     +4     
  Branches     2715     2837   +122     
========================================
+ Hits        11635    11639     +4     
  Misses        850      850            
  Partials        1        1            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Fernando Rijo Cedeno <[email protected]>
@zFernand0 zFernand0 changed the title Fix 3327 fix: Avoid data-loss when creating new members Jan 13, 2025
Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this Fernando! I tested this and its working as expected. I had a question about a set of line comments, but aside from that everything LGTM.

Signed-off-by: Fernando Rijo Cedeno <[email protected]>
@zFernand0 zFernand0 requested a review from traeok January 13, 2025 22:32
traeok
traeok previously approved these changes Jan 14, 2025
Co-authored-by: Trae Yelovich <[email protected]>
Signed-off-by: Fernando Rijo Cedeno <[email protected]>
Copy link
Member

@t1m0thyj t1m0thyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @zFernand0!

@t1m0thyj t1m0thyj added this to the v3.1.0 milestone Jan 14, 2025
@JillieBeanSim JillieBeanSim merged commit d5ad25f into main Jan 14, 2025
24 checks passed
@JillieBeanSim JillieBeanSim deleted the fix-3327 branch January 14, 2025 17:04
@JillieBeanSim
Copy link
Contributor

Thanks @zFernand0 let us know in slack when the cherry-pick PR is ready so we can get it included in our 3.1.0 testing 😄

zFernand0 added a commit that referenced this pull request Jan 14, 2025
* fix: Prompt users when creating members if the member exists

Signed-off-by: Fernando Rijo Cedeno <[email protected]>

* review: alternative way

Signed-off-by: Fernando Rijo Cedeno <[email protected]>

* test: add coverage for added memberFound logic

Signed-off-by: Fernando Rijo Cedeno <[email protected]>

* chore: update changelog

Signed-off-by: Fernando Rijo Cedeno <[email protected]>

* chore: cleanup commented code

Signed-off-by: Fernando Rijo Cedeno <[email protected]>

* chore: simplify fix 😋

Signed-off-by: Fernando Rijo Cedeno <[email protected]>

* Update packages/zowe-explorer/CHANGELOG.md

Co-authored-by: Trae Yelovich <[email protected]>
Signed-off-by: Fernando Rijo Cedeno <[email protected]>

---------

Signed-off-by: Fernando Rijo Cedeno <[email protected]>
Co-authored-by: Trae Yelovich <[email protected]>
zFernand0 added a commit that referenced this pull request Jan 16, 2025
* fix: Avoid data-loss when creating new members (#3392)

* fix: Prompt users when creating members if the member exists

Signed-off-by: Fernando Rijo Cedeno <[email protected]>

* review: alternative way

Signed-off-by: Fernando Rijo Cedeno <[email protected]>

* test: add coverage for added memberFound logic

Signed-off-by: Fernando Rijo Cedeno <[email protected]>

* chore: update changelog

Signed-off-by: Fernando Rijo Cedeno <[email protected]>

* chore: cleanup commented code

Signed-off-by: Fernando Rijo Cedeno <[email protected]>

* chore: simplify fix 😋

Signed-off-by: Fernando Rijo Cedeno <[email protected]>

* Update packages/zowe-explorer/CHANGELOG.md

Co-authored-by: Trae Yelovich <[email protected]>
Signed-off-by: Fernando Rijo Cedeno <[email protected]>

---------

Signed-off-by: Fernando Rijo Cedeno <[email protected]>
Co-authored-by: Trae Yelovich <[email protected]>

* chore: move the changelog entry to the right location

Signed-off-by: Fernando Rijo Cedeno <[email protected]>

---------

Signed-off-by: Fernando Rijo Cedeno <[email protected]>
Co-authored-by: Trae Yelovich <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ported Apply to issues or PRs that need ported size/M
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

tree(ds): Creating a new member with a conflicting name may cause data-loss
4 participants