Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Avoid data-loss when creating new members (#3392) #3397

Merged
merged 2 commits into from
Jan 16, 2025

Conversation

zFernand0
Copy link
Member

Proposed changes

Release Notes

Milestone: 3.1.0

Changelog: Fixed data loss when creating a data set member with the same name as an existing member. When creating a new member, the user is now prompted to replace it if the member already exists.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds or improves functionality)
  • Breaking change (a change that would cause existing functionality to not work as expected)
  • Documentation (Markdown, README updates)
  • Other (please specify above in "Proposed changes" section)

Checklist

General

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • All PR dependencies have been merged and published (if applicable)
  • A GIF or screenshot is included in the PR for visual changes
  • The pre-publish command has been executed:
    • v2 and below: yarn workspace vscode-extension-for-zowe vscode:prepublish
    • v3: pnpm --filter vscode-extension-for-zowe vscode:prepublish

Code coverage

  • There is coverage for the code that I have added
  • I have added new test cases and they are passing
  • I have manually tested the changes

Deployment

  • I have added developer documentation (if applicable)
  • Documentation should be added to Zowe Docs
    • If you're an outside contributor, please post in the #zowe-doc Slack channel to coordinate documentation.
    • Otherwise, please check with the rest of the squad about any needed documentation before merging.
  • These changes may need ported to the appropriate branches (list here):

Further comments

zFernand0 and others added 2 commits January 14, 2025 13:27
* fix: Prompt users when creating members if the member exists

Signed-off-by: Fernando Rijo Cedeno <[email protected]>

* review: alternative way

Signed-off-by: Fernando Rijo Cedeno <[email protected]>

* test: add coverage for added memberFound logic

Signed-off-by: Fernando Rijo Cedeno <[email protected]>

* chore: update changelog

Signed-off-by: Fernando Rijo Cedeno <[email protected]>

* chore: cleanup commented code

Signed-off-by: Fernando Rijo Cedeno <[email protected]>

* chore: simplify fix 😋

Signed-off-by: Fernando Rijo Cedeno <[email protected]>

* Update packages/zowe-explorer/CHANGELOG.md

Co-authored-by: Trae Yelovich <[email protected]>
Signed-off-by: Fernando Rijo Cedeno <[email protected]>

---------

Signed-off-by: Fernando Rijo Cedeno <[email protected]>
Co-authored-by: Trae Yelovich <[email protected]>
Copy link

📅 Suggested merge-by date: 1/28/2025

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.18%. Comparing base (b2351d2) to head (416c78f).
Report is 1 commits behind head on release/3.1.

Additional details and impacted files
@@             Coverage Diff              @@
##           release/3.1    #3397   +/-   ##
============================================
  Coverage        93.18%   93.18%           
============================================
  Files              120      120           
  Lines            12486    12490    +4     
  Branches          2835     2837    +2     
============================================
+ Hits             11635    11639    +4     
  Misses             850      850           
  Partials             1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@JillieBeanSim JillieBeanSim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the fix @zFernand0

@zFernand0 zFernand0 requested a review from awharn January 15, 2025 14:37
Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cherry-picking @zFernand0! LGTM

@zFernand0 zFernand0 merged commit f2e6c59 into release/3.1 Jan 16, 2025
24 checks passed
@zFernand0 zFernand0 deleted the cp-pr-3392 branch January 16, 2025 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

3 participants