-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Avoid data-loss when creating new members (#3392) #3397
Conversation
* fix: Prompt users when creating members if the member exists Signed-off-by: Fernando Rijo Cedeno <[email protected]> * review: alternative way Signed-off-by: Fernando Rijo Cedeno <[email protected]> * test: add coverage for added memberFound logic Signed-off-by: Fernando Rijo Cedeno <[email protected]> * chore: update changelog Signed-off-by: Fernando Rijo Cedeno <[email protected]> * chore: cleanup commented code Signed-off-by: Fernando Rijo Cedeno <[email protected]> * chore: simplify fix 😋 Signed-off-by: Fernando Rijo Cedeno <[email protected]> * Update packages/zowe-explorer/CHANGELOG.md Co-authored-by: Trae Yelovich <[email protected]> Signed-off-by: Fernando Rijo Cedeno <[email protected]> --------- Signed-off-by: Fernando Rijo Cedeno <[email protected]> Co-authored-by: Trae Yelovich <[email protected]>
Signed-off-by: Fernando Rijo Cedeno <[email protected]>
📅 Suggested merge-by date: 1/28/2025 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/3.1 #3397 +/- ##
============================================
Coverage 93.18% 93.18%
============================================
Files 120 120
Lines 12486 12490 +4
Branches 2835 2837 +2
============================================
+ Hits 11635 11639 +4
Misses 850 850
Partials 1 1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the fix @zFernand0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for cherry-picking @zFernand0! LGTM
Proposed changes
Release Notes
Milestone: 3.1.0
Changelog: Fixed data loss when creating a data set member with the same name as an existing member. When creating a new member, the user is now prompted to replace it if the member already exists.
Types of changes
Checklist
General
yarn workspace vscode-extension-for-zowe vscode:prepublish
pnpm --filter vscode-extension-for-zowe vscode:prepublish
Code coverage
Deployment
Further comments