Fix error when issuing TSO commands

CHANGELOG.md

@@ -2,6 +2,12 @@
 
 All notable changes to the Zowe Client Python SDK will be documented in this file.
 
+## Recent Changes
+
+### Bug Fixes
+
+- Fixed error when issuing TSO commands [#255](https://github.com/zowe/zowe-client-python-sdk/issues/255)
+
 ## `1.0.0-dev14`
 
 ### Enhancements

src/zos_tso/zowe/zos_tso_for_zowe_sdk/tso.py

@@ -10,6 +10,8 @@
 Copyright Contributors to the Zowe Project.
 """
 
+import json
+
 from zowe.core_for_zowe_sdk import SdkApi, constants
 
 
@@ -126,7 +128,9 @@ def send_tso_message(self, session_key, message):
         """
         custom_args = self._create_custom_request_arguments()
         custom_args["url"] = "{}/{}".format(self.request_endpoint, str(session_key))
-        custom_args["json"] = {"TSO RESPONSE": {"VERSION": "0100", "DATA": str(message)}}
+        # z/OSMF TSO API requires json to be formatted in specific way without spaces
+        request_json = {"TSO RESPONSE": {"VERSION": "0100", "DATA": str(message)}}
+        custom_args["data"] = json.dumps(request_json, separators=(",", ":"))
         response_json = self.request_handler.perform_request("PUT", custom_args)
         return response_json["tsoData"]
 

tests/integration/test_zos_tso.py

@@ -1,4 +1,5 @@
 """Integration tests for the Zowe Python SDK z/OS Tso package."""
+
 import unittest
 
 from zowe.core_for_zowe_sdk import ProfileManager
@@ -17,6 +18,7 @@ def test_issue_command_should_return_valid_response(self):
         """Executing the issue_command method should return a valid response from TSO"""
         command_output = self.tso.issue_command("TIME")
         self.assertIsInstance(command_output, list)
+        self.assertIn("TIME", command_output[0])
 
     def test_start_tso_session_should_return_a_session_key(self):
         """Executing the start_tso_session method should return a valid TSO session key"""

tests/unit/test_zos_tso.py

@@ -1,16 +1,16 @@
 """Unit tests for the Zowe Python SDK z/OS TSO package."""
 
-import unittest
+from unittest import TestCase, mock
 
 from zowe.zos_tso_for_zowe_sdk import Tso
 
 
-class TestTsoClass(unittest.TestCase):
+class TestTsoClass(TestCase):
     """Tso class unit tests."""
 
     def setUp(self):
         """Setup fixtures for Tso class."""
-        self.connection_dict = {
+        self.test_profile = {
             "host": "mock-url.com",
             "user": "Username",
             "password": "Password",
@@ -20,5 +20,16 @@ def setUp(self):
 
     def test_object_should_be_instance_of_class(self):
         """Created object should be instance of Tso class."""
-        tso = Tso(self.connection_dict)
+        tso = Tso(self.test_profile)
         self.assertIsInstance(tso, Tso)
+
+    @mock.patch("requests.Session.send")
+    def test_issue_command(self, mock_send_request):
+        """Test issuing a command sends a request"""
+        fake_response = {"servletKey": None, "tsoData": "READY"}
+        mock_send_request.return_value = mock.Mock(
+            headers={"Content-Type": "application/json"}, status_code=200, json=lambda: fake_response
+        )
+
+        Tso(self.test_profile).issue_command("TIME")
+        self.assertEqual(mock_send_request.call_count, 3)