Fix error when issuing TSO commands #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Timothy Johnson <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #257 +/- ##
==========================================
+ Coverage 83.83% 84.88% +1.04%
==========================================
Files 34 34
Lines 2116 2124 +8
==========================================
+ Hits 1774 1803 +29
+ Misses 342 321 -21
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Timothy Johnson <[email protected]>
awharn
approved these changes
Mar 13, 2024
traeok
approved these changes
Mar 13, 2024
|
Release succeeded for the The following packages have been published:
Powered by Octorelease 🚀 |
zFernand0
reviewed
Mar 13, 2024
|
|
||
| @mock.patch("requests.Session.send") | ||
| def test_issue_command(self, mock_send_request): | ||
| """Test issuing a command sends a request""" |
There was a problem hiding this comment.
Should we change the test description to something like should ... ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #255 and updates the system test for
Tso.issue_commandto verify that the response is successful