Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-231 Now 'issue_command' can use custom console name #232

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

KUGDev
Copy link
Contributor

@KUGDev KUGDev commented Nov 23, 2023

What It Does

How to Test

Review Checklist
I certify that I have:

Additional Comments

Copy link

codecov bot commented Nov 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b62f6ec) 83.16% compared to head (4f43a68) 83.54%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #232      +/-   ##
==========================================
+ Coverage   83.16%   83.54%   +0.37%     
==========================================
  Files          34       34              
  Lines        2067     2084      +17     
==========================================
+ Hits         1719     1741      +22     
+ Misses        348      343       -5     
Flag Coverage Δ
unittests 83.54% <100.00%> (+0.37%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@t1m0thyj t1m0thyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @KUGDev!

@t1m0thyj
Copy link
Member

Going to merge and publish as 1.0.0-dev12 (prerelease) shortly.

@t1m0thyj t1m0thyj merged commit cfb9bcb into zowe:main Nov 28, 2023
23 checks passed
@KUGDev KUGDev deleted the fix/GH-231-defcn-in-issue-command branch November 28, 2023 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'defcn' console name is always used in 'issue_command' Console API function
3 participants