Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only one error format for V3 & remove references to bright #1859

Merged
merged 12 commits into from
Nov 14, 2023

Conversation

gejohnston
Copy link
Member

What It Does

The revised format of Zowe CLI error messages (which was an option controlled by the environment variable ZOWE_V3_ERR_FORMAT during V2) is the only error format used by Zowe CLI in V3.

Also remove all references to 'bright' and 'brightside' within the app.

Closes #1792

How to Test

You can test that the new error format is automatically being used by issuing the following erroneous command.

zowe zos-files list all-members "DATASET.DOES.NOT.EXIST"

The output will begin with the text:

Unable to perform this operation due to the following problem.
ISRZ002 Data set not cataloged - 'DATASET.DOES.NOT.EXIST' was not found in catalog.

You can confirm that the bright command is gone by installing zowe-cli into a clean environment. You then will get an error like the following when using the bright command.

> bright --version
bright: The term 'bright' is not recognized as a name of a cmdlet, function, script file, or executable program.
Check the spelling of the name, or if a path was included, verify that the path is correct and try again.

Review Checklist
I certify that I have:

Additional Comments

Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (dbcdf64) 91.06% compared to head (5181eb2) 91.04%.
Report is 1 commits behind head on next.

Files Patch % Lines
...perative/src/cmd/src/yargs/AbstractCommandYargs.ts 0.00% 5 Missing ⚠️
...kages/imperative/src/cmd/src/yargs/CommandYargs.ts 50.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             next    #1859      +/-   ##
==========================================
- Coverage   91.06%   91.04%   -0.02%     
==========================================
  Files         636      636              
  Lines       18709    18660      -49     
  Branches     3898     3871      -27     
==========================================
- Hits        17037    16989      -48     
+ Misses       1671     1670       -1     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @gejohnston!

Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

50.0% 50.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for removing some snapshots 😋

@zFernand0 zFernand0 mentioned this pull request Nov 14, 2023
4 tasks
@zFernand0 zFernand0 merged commit 819985f into next Nov 14, 2023
18 checks passed
@zFernand0 zFernand0 deleted the next-v3-err-fmt branch November 14, 2023 14:33
@zFernand0 zFernand0 added the release-current Indicates that there is no new functionality being delivered label Nov 14, 2023
Copy link

Release succeeded for the next branch. 🎉

The following packages have been published:

Powered by Octorelease 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog release-current Indicates that there is no new functionality being delivered released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants