-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only one error format for V3 & remove references to bright #1859
Conversation
Signed-off-by: Gene Johnston <[email protected]>
Signed-off-by: Gene Johnston <[email protected]>
Signed-off-by: Gene Johnston <[email protected]>
Signed-off-by: Gene Johnston <[email protected]>
Signed-off-by: Gene Johnston <[email protected]>
Signed-off-by: Gene Johnston <[email protected]>
Signed-off-by: Gene Johnston <[email protected]>
Signed-off-by: Gene Johnston <[email protected]>
Signed-off-by: Gene Johnston <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## next #1859 +/- ##
==========================================
- Coverage 91.06% 91.04% -0.02%
==========================================
Files 636 636
Lines 18709 18660 -49
Branches 3898 3871 -27
==========================================
- Hits 17037 16989 -48
+ Misses 1671 1670 -1
Partials 1 1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Gene Johnston <[email protected]>
Signed-off-by: Gene Johnston <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @gejohnston!
SonarCloud Quality Gate failed. 0 Bugs 50.0% Coverage Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for removing some snapshots 😋
Release succeeded for the The following packages have been published:
Powered by Octorelease 🚀 |
What It Does
The revised format of Zowe CLI error messages (which was an option controlled by the environment variable ZOWE_V3_ERR_FORMAT during V2) is the only error format used by Zowe CLI in V3.
Also remove all references to 'bright' and 'brightside' within the app.
Closes #1792
How to Test
You can test that the new error format is automatically being used by issuing the following erroneous command.
The output will begin with the text:
You can confirm that the
bright
command is gone by installing zowe-cli into a clean environment. You then will get an error like the following when using thebright
command.Review Checklist
I certify that I have:
Additional Comments