-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix peer dependencies in Next #1961
Conversation
Signed-off-by: Andrew W. Harn <[email protected]>
Signed-off-by: Andrew W. Harn <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @awharn!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #1961 +/- ##
=======================================
Coverage 91.06% 91.06%
=======================================
Files 636 636
Lines 18709 18709
Branches 3898 3898
=======================================
Hits 17037 17037
Misses 1671 1671
Partials 1 1 ☔ View full report in Codecov by Sentry. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even after doing something similar to this, I had to pass the force: true
flag on the scripts/rewriteShrinkwrap.js
script during a test I was doing on another PR 😋
LGTM! 😋
combining with: |
What It Does
The peer deps are not updated in Next. This should fix that.
How to Test
Review Checklist
I certify that I have:
Additional Comments