Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix peer dependencies in Next #1961

Merged
merged 2 commits into from
Nov 14, 2023
Merged

Fix peer dependencies in Next #1961

merged 2 commits into from
Nov 14, 2023

Conversation

awharn
Copy link
Member

@awharn awharn commented Nov 13, 2023

What It Does
The peer deps are not updated in Next. This should fix that.

How to Test

Review Checklist
I certify that I have:

Additional Comments

Signed-off-by: Andrew W. Harn <[email protected]>
@awharn awharn changed the title Fix peer dependencies Fix peer dependencies in Next Nov 13, 2023
Signed-off-by: Andrew W. Harn <[email protected]>
Copy link
Member

@t1m0thyj t1m0thyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @awharn!

Copy link

codecov bot commented Nov 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7ad0709) 91.06% compared to head (dbcdf64) 91.06%.
Report is 2 commits behind head on next.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #1961   +/-   ##
=======================================
  Coverage   91.06%   91.06%           
=======================================
  Files         636      636           
  Lines       18709    18709           
  Branches     3898     3898           
=======================================
  Hits        17037    17037           
  Misses       1671     1671           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even after doing something similar to this, I had to pass the force: true flag on the scripts/rewriteShrinkwrap.js script during a test I was doing on another PR 😋
LGTM! 😋

@zFernand0 zFernand0 merged commit deb86b2 into next Nov 14, 2023
20 checks passed
@zFernand0 zFernand0 deleted the fix-peer-deps-for-next branch November 14, 2023 13:51
@zFernand0
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants