Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update sample plugin to make compatible with vnext #101

Merged
merged 23 commits into from
Mar 15, 2024
Merged

Update sample plugin to make compatible with vnext #101

merged 23 commits into from
Mar 15, 2024

Conversation

ATorrise
Copy link
Contributor

@ATorrise ATorrise commented Mar 13, 2024 •
edited
Loading

What It Does

  • Update imports and resolve errors such that the sample CLI plug-in can be used by plug-in developers to create V3-compatible Zowe CLI plug-ins.
  • Restructures and updates the readme.
  • Removes any references to jenkins or jenkins files.
  • Ensure that you can build and install the plugin as a plugin using zowe cli 8.x & confirm that sample plugin command group is accessible.

How to Test
Test that this branch can build a working plugin that runs the sample command zowe zowe-cli-sample list directory-contents

Review Checklist
I certify that I have:

Amber Torrise added 8 commits March 14, 2024 10:18
removing cicd detailed information and switching to GHA
35bad5f 
Signed-off-by: Amber Torrise <[email protected]>
adding back pluginlifecycle to plugin test. got wires crossed about p…
ec62df2 
…luginhealthcheck

Signed-off-by: Amber Torrise <[email protected]>
adding back
57dfc17 
Signed-off-by: Amber Torrise <[email protected]>
renaming file to correct spelling
719d590 
Signed-off-by: Amber Torrise <[email protected]>
updating spellings and documentation
fc4f870 
Signed-off-by: Amber Torrise <[email protected]>
condensing documentation and making easier to follow
27350aa 
Signed-off-by: Amber Torrise <[email protected]>
fix link in readme
d2aa55e 
Signed-off-by: Amber Torrise <[email protected]>
minor fixes
3f709fd 
Signed-off-by: Amber Torrise <[email protected]>
@ATorrise ATorrise marked this pull request as ready for review March 14, 2024 17:45
anaxceron
anaxceron approved these changes Mar 14, 2024
View reviewed changes
Copy link

@anaxceron anaxceron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one suggestion -- lookin' good, thank you @ATorrise

CHANGELOG.md Show resolved Hide resolved
zFernand0
zFernand0 approved these changes Mar 14, 2024
View reviewed changes
Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😋
left a few questions/comments

package.json Outdated Show resolved Hide resolved
docs/tutorials/profile-example/ProfilePlugin.md Outdated Show resolved Hide resolved
docs/tutorials/list-typicode-todo/ListTypicodeTodoPlugin.md Outdated Show resolved Hide resolved
src/pluginDef.ts Outdated Show resolved Hide resolved
docs/tutorials/list-directory-contents/ListDirectoryContentsPlugin.md Outdated Show resolved Hide resolved
docs/tutorials/list-directory-contents/ListDirectoryContentsPlugin.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Amber Torrise added 2 commits March 14, 2024 15:26
corrections based on comments
9a2f0b4 
Signed-off-by: Amber Torrise <[email protected]>
fix pluginDef.pluginLifeCycle
686d4db 
Signed-off-by: Amber Torrise <[email protected]>
@ATorrise ATorrise linked an issue Mar 14, 2024 that may be closed by this pull request
Update the sample plug-in to be V3-compatible #96
Closed
zFernand0
zFernand0 reviewed Mar 14, 2024
View reviewed changes
Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for being so quick to address the comments,
will re-approve once the build is ok 😋

package.json Outdated Show resolved Hide resolved
@zFernand0 zFernand0 self-requested a review March 14, 2024 19:38
Amber Torrise added 3 commits March 14, 2024 15:44
fixing versioning and also removing mroe profile-related logic
334554b 
Signed-off-by: Amber Torrise <[email protected]>
updating snaps
90a678b 
Signed-off-by: Amber Torrise <[email protected]>
seeing if tests pass
2fb47fd 
Signed-off-by: Amber Torrise <[email protected]>
Amber Torrise added 2 commits March 14, 2024 16:34
zFernand0
zFernand0 approved these changes Mar 14, 2024
View reviewed changes
Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😋
left a few comments, but so far so good 😋

CONTRIBUTING.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
docs/tutorials/files-util/FilesUtilPlugin.md Show resolved Hide resolved
docs/tutorials/list-typicode-todo/ListTypicodeTodoPlugin.md Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/cli/list/profile-args/ProfileArgs.handler.ts Outdated Show resolved Hide resolved
@ATorrise ATorrise requested a review from zFernand0 March 15, 2024 16:37
@ATorrise ATorrise changed the base branch from master to next March 15, 2024 18:05
Amber Torrise added 2 commits March 15, 2024 14:39
changes requested by tim
0097557 
Signed-off-by: Amber Torrise <[email protected]>
typo!
79c3fd0 
Signed-off-by: Amber Torrise <[email protected]>
zFernand0
zFernand0 approved these changes Mar 15, 2024
View reviewed changes
Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the feedback so quickly 🥳

And also for allowing the vNext prerelease to go out 😋

LGTM! 😋

@zFernand0 zFernand0 merged commit 6c8aeeb into next Mar 15, 2024
16 checks passed
@zFernand0 zFernand0 deleted the update-sample-plugin branch March 15, 2024 19:10
@github-actions GitHub Actions
Copy link

Release succeeded for the next branch. 🎉

The following packages have been published:

Powered by Octorelease 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anaxceron anaxceron anaxceron approved these changes

@adam-wolfe adam-wolfe adam-wolfe approved these changes

@zFernand0 zFernand0 zFernand0 approved these changes

@gejohnston gejohnston Awaiting requested review from gejohnston

@t1m0thyj t1m0thyj Awaiting requested review from t1m0thyj

@awharn awharn Awaiting requested review from awharn

@traeok traeok Awaiting requested review from traeok

Assignees

@ATorrise ATorrise

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update the sample plug-in to be V3-compatible
5 participants
@ATorrise @t1m0thyj @zFernand0 @anaxceron @adam-wolfe