Remove node 14 dns check in start.sh #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: 1000TurquoisePogs <[email protected]>
Signed-off-by: 1000TurquoisePogs <[email protected]>
struga0258
approved these changes
Jun 14, 2024
skurnevich
approved these changes
Jun 14, 2024
There was a problem hiding this comment.
Node docs state that --dns-result-order was added in: v16.4.0, v14.18.0, so there could be a case with Node 16.0.0 - 16.3.0 which will not be handled, however Node v16 going to be end of support Sep 2024, so it looks minor and should be ok.
|
Agreed @skurnevich but I couldn't find evidence z/OS ever had a v16 that old. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In node 18, node prefers ipv6 results in dns by default and so we override that with a flag. This flag does not exist on node 14.
So, we had a check by which we'd run node and if it crashed, we'd know the flag wasnt allowed and then not use it.
This is no longer needed because node 14 is no longer supported by zowe.
By removing this check, we save some startup time because we do not need to spawn node just to figure out if it works or not.
Note: you cannot even start with node14 anymore.
This is prevented in the "zwe" startup process by the validation phase of prepare.
It will say "node ${version} is less than the minimum level required of v${NODE_MIN_VERSION}"