Skip to content

Commit

Permalink
Merge pull request #304 from zowe/chore/v2/node-14-dns-check
Browse files Browse the repository at this point in the history
Remove node 14 dns check in start.sh
  • Loading branch information
1000TurquoisePogs authored Jun 17, 2024
2 parents 176e9f6 + 126645a commit 83cb2e1
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 6 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ All notable changes to the Zlux App Server package will be documented in this fi

## v2.17.0
- Enhancement: app-server can now use Zowe's standardized and simplified AT-TLS configuration simply by toggling `zowe.network.server.tls.attls: true` or `components.app-server.zowe.network.server.tls.attls: true`. If you wish to control client tls separately from server tls, you can also use `zowe.network.client.tls.attls` or `components.app-server.zowe.network.client.tls.attls`. (#300)
- Enhancement: Remove dns check specific to node 14 and below to reduce startup time. Node 14 has not been supported since september 2023. (#304)

## v2.16.0
- Bugfix: Removed message saying node not found prior to discovery of node. Now, you will only get an error message if node is not found after lookup in NODE_HOME.
Expand Down
6 changes: 0 additions & 6 deletions bin/start.sh
Original file line number Diff line number Diff line change
Expand Up @@ -95,12 +95,6 @@ if [ "$ZWE_components_app_server_dns_lookupOrder" = "ipv6" ]; then
ZLUX_DNS_ORDER="--dns-result-order=verbatim"
fi

# not all versions of node support the above (14.18+ generally) so we can just try it to see what happens.
v4_check=$(${NODE_BIN} ${ZLUX_DNS_ORDER} -e "console.log('success');")
if [ "${v4_check}" != "success" ]; then
ZLUX_DNS_ORDER=
fi

if [ -z "${ZWED_FLAGS}" ]; then
ZWED_FLAGS="${ZLUX_DNS_ORDER} --harmony "
fi
Expand Down

0 comments on commit 83cb2e1

Please sign in to comment.