Add schema and default for getting all discovery servers instead of just one #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ust one Signed-off-by: 1000TurquoisePogs <[email protected]>
Signed-off-by: 1000TurquoisePogs <[email protected]>
timgerstel
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The app-server had some behavior where it would sometimes contact the discovery server(s) from the value node.mediationLayer.server.hostname, and other times access from the environment variable ZWE_DISCOVERY_SERVICES_LIST which could contain multiple entries.
It is proper to use a list for discovery whenever possible as the server may need to contact multiple, or failover when one is not found.
Changing the meaning of "hostname" would be a breaking change. Therefore instead I have marked it as deprecated and introduced a new "discoveryUrls" array to clarify that multiple discovery servers may exist.
I have an uncertainty around the container behavior conditional, and will schedule an additional test on it.