Fixes and enhancements for handling multiple discovery servers #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…W message. Add message ID for checkAgent warning. Fix checkAgent for when multiple discovery servers are present. Signed-off-by: 1000TurquoisePogs <[email protected]>
Signed-off-by: 1000TurquoisePogs <[email protected]>
Signed-off-by: 1000TurquoisePogs <[email protected]>
timgerstel
approved these changes
Jan 9, 2024
Signed-off-by: 1000TurquoisePogs <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug in the server where if multiple discovery servers exist, checkAgent() will only contact the first one, and if it is unreachable, the other servers will not be checked, and the app-server will retry the first until quitting.
When investigating this, I've also cleaned up "hostname" versus "gatewayHostname" occurrences now that the distinction exists.
This PR requires zowe/zlux-app-server#290