Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[issue-4336] halt launch requested notifications on projects #4373

Merged
merged 1 commit into from
Aug 5, 2024
Merged

[issue-4336] halt launch requested notifications on projects #4373

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions app/models/project.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,8 +118,6 @@ def send_notifications
if Panoptes.project_request.recipients
request_type = if saved_change_to_beta_requested? && beta_requested
"beta"
elsif saved_change_to_launch_requested? && launch_requested
"launch"
end
ProjectRequestEmailWorker.perform_async(request_type, id) if request_type
end
Expand Down
19 changes: 0 additions & 19 deletions spec/models/project_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -483,25 +483,6 @@
end
end
end

context "when launch_requested changed" do
let(:field) { "launch_requested" }

context "when true" do
let(:value) { true }
it 'should queue the worker' do
expect(ProjectRequestEmailWorker).to receive(:perform_async).with("launch", project.id)
end
end

context "when false" do
let(:value) { false }

it 'should not queue the worker' do
expect(ProjectRequestEmailWorker).not_to receive(:perform_async)
end
end
end
end
end

Expand Down
Loading