Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[issue-4336] halt launch requested notifications on projects #4373

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

Tooyosi
Copy link
Contributor

@Tooyosi Tooyosi commented Aug 5, 2024

Describe your change here.

Remove launch email notifications from Projects

Review checklist

  • First, the most important one: is this PR small enough that you can actually review it? Feel free to just reject a branch if the changes are hard to review due to the length of the diff.
  • If there are any migrations, will they the previous version of the app work correctly after they've been run (e.g. the don't remove columns still known about by ActiveRecord).
  • If anything changed with regards to the public API, are those changes also documented in the apiary.apib file?
  • Are all the changes covered by tests? Think about any possible edge cases that might be left untested.

@lcjohnso
Copy link
Member

lcjohnso commented Aug 5, 2024

Looks good to me; accomplishes the goal to remove the project launch_requested change mailer.

@Tooyosi Tooyosi merged commit 78abe37 into master Aug 5, 2024
8 checks passed
@Tooyosi Tooyosi deleted the 4366-halt-all-but-beta-request-emails branch August 5, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants