Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove temporary banners from app layouts #6479

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Conversation

goplayoutside3
Copy link
Contributor

@goplayoutside3 goplayoutside3 commented Nov 19, 2024

Package

app-root
app-project

Linked Issue and/or Talk Post

Reversion of #6456
Corresponding PFE PR: zooniverse/Panoptes-Front-End#7221

Describe your changes

  • Remove <details> component from layouts.

How to Review

  • app-root should run locally without the banner
  • app-project should run locally without the banner

Checklist

PR Creator - Please cater the checklist to fit the review needed for your code changes.
PR Reviewer - Use the checklist during your review. Each point should be checkmarked or discussed before PR approval.

General

  • Tests are passing locally and on Github
  • Documentation is up to date and changelog has been updated if appropriate
  • You can yarn panic && yarn bootstrap or docker-compose up --build and FEM works as expected

@coveralls
Copy link

Coverage Status

coverage: 77.873% (+0.005%) from 77.868%
when pulling a6c68cb on remove-temp-banners
into c146bdf on master.

@kieftrav kieftrav force-pushed the remove-temp-banners branch from 77139e7 to 0b6fa71 Compare November 21, 2024 15:11
@kieftrav kieftrav merged commit 74d5ede into master Nov 21, 2024
8 checks passed
@kieftrav kieftrav deleted the remove-temp-banners branch November 21, 2024 15:18
@github-actions github-actions bot added the approved This PR is approved for merging label Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This PR is approved for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants