Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove temporary banner from layout #7221

Merged
merged 2 commits into from
Nov 21, 2024
Merged

Remove temporary banner from layout #7221

merged 2 commits into from
Nov 21, 2024

Conversation

goplayoutside3
Copy link
Contributor

@goplayoutside3 goplayoutside3 commented Nov 19, 2024

Staging branch URL: https://pr-7221.pfe-preview.zooniverse.org/projects

Reverts: #7217
Corresponding FEM PR: zooniverse/front-end-monorepo#6479

How To Review

The temporary banner should no longer be visible at the above staged url.

@coveralls
Copy link

coveralls commented Nov 19, 2024

Coverage Status

coverage: 56.684%. remained the same
when pulling 258c247 on remove-temp-banner
into 8ad3b19 on master.

Copy link
Member

@shaunanoordin shaunanoordin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Review

This is a straightforward removal of the temporary banner element. LGTM, merge & deploy whenever the downtime is complete. 👍

@kieftrav kieftrav merged commit 39a09e8 into master Nov 21, 2024
5 checks passed
@kieftrav kieftrav deleted the remove-temp-banner branch November 21, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants