Validate project before allowing beta submission

[rogerhutchings]

Following on from a first crack at this in #3523, this adds validation before allowing a beta review submission. It uses set_member_subjects_count which is known to be wrong for some projects (zooniverse/panoptes#2155), so this PR is blocked until that bug is fixed but we're ignoring it for now.

Adds the babel-rewire plugin to allow mocking the apiClient, so will need an npm install before testing locally.

Review Checklist

• Does it work in all major browsers: Firefox, Chrome, Edge, Safari?
• Does it work on mobile?
• Can you rm -rf node_modules/ && npm install and app works as expected?
• Did you deploy a staging branch? https://validate-project-subjects.pfe-preview.zooniverse.org/
• Did you get any type checking errors from Babel Typecheck

Optional

• If it's a new component, is it in ES6? Is it clear of warnings from ESLint?
• Have you replaced any ChangeListener or PromiseRenderer components with code that updates component state?
• If changes are made to the classifier, does the dev classifier still work?
• Have you added in flow type annotations?

[mention-bot]

@rogerhutchings, thanks for your PR! By analyzing the history of the files in this pull request, we identified @srallen and @saschaishikawa to be potential reviewers.

[camallen]

@rogerhutchings don't wait on the panoptes issue to get sorted.

[rogerhutchings]

Cool. I'm going to rewrite this in ES6 with tests in any case, so I'll request a review when it's done.

[rogerhutchings]

Okay, this is complete. I've also managed to mock the apiClient, which may be of interest with other tests.

[shaunanoordin]

PR Review

• As a Project Owner, when I go to Build a Project -> (Edit My Project) -> Visibility, under the Beta Status section, if I've ticked all the checkboxes, I can choose Apply for Review
• If my Project does not meet the minimum requirements (>= 100 Subjects, have FAQ and Research pages), then my Beta application should be prevented.
• If my Project does meet the minimum requirements, my Beta application should be submitted.

The Visibility page upon clicking 'Apply for Review' and being prevented from submitting

• Tested on OSX+Chrome on localhost.
  • Note that, at the moment, I'm still reviewing the code & running further tests to confirm that the "Submit Beta Application" functionality works.

While I can confirm the functionality for the "Prevent Beta Application", I would like to raise a UI concern.

UI Issue: "Could not Apply for Beta" error message needs to be more obvious

Details:
The "The following errors need to be fixed..." message (see above image) appears immediately after the "Apply for Review" button is clicked and with little fanfare. I initially didn't realise my Application for Beta failed, and the only reason I noticed something was amiss was because - as a dev reviewing the feature - I was actively looking for the error message.

I would argue the UI matter is a non-blocking issue, but would like to have it flagged for future review at minimum.

[rogerhutchings]

Errors now look like this:

[shaunanoordin]

PR Review (Update)

• The new up UI changes make the errors much more explicit. (Visually, not language-wise. Although that would have been hilarious.)
• Testing for "Prevent Beta application" works as before, but I could not fully test "Submit Beta application" due to an upload limit on my testing account. That said, code looks logical enough to me, so I have no strong concerns.
• Tests OK on localhost for OSX+Chrome56/FF51, Win7+IE11

Status

LGTM, approval go!