-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate project before allowing beta application #3523
Conversation
@rogerhutchings, thanks for your PR! By analyzing the history of the files in this pull request, we identified @srallen and @saschaishikawa to be potential reviewers. |
@rogerhutchings I wouldn't require all of the about pages to be filled if I read this correctly. Because on the about section is results that won't necessarily be filled out. None of my panoptes projects did I put content at launch, since those are supposed to be for news about results from then project. Also for example there's an Education tab, we didn't make one for P4: Ridges because there's not really much a class could do with that project that we could think of so we skipped that page. Can you just check the FAQ and the research are pages are filled out only? I think those are two that should be required, but everything else I think depending on the project could be optional. |
or maybe just count for 3 pages:about, faq, and team ( as team is autogenerated)? |
I just want to point out that this validation uses |
@mschwamb Fair enough on Results, I'll change it to require two pages called "Research" and "FAQ". "Team" isn't actually autogenerated as a page, only the list of collaborators; there's also a page resource called Team that goes with it. @CKrawczyk Good catch - I can separate this into two PRs so we can get the other validations in now. |
…check while waiting for counters to be updated
Now requires the following statements to be true about a project before an owner can apply for beta:
Must have at least 100 subjects in active workflowssee below@mrniaboc
Review Checklist
rm -rf node_modules/ && npm install
and app works as expected?Optional
ChangeListener
orPromiseRenderer
components with code that updates component state?