Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate project before allowing beta application #3523

Closed
wants to merge 7 commits into from

Conversation

rogerhutchings
Copy link
Contributor

@rogerhutchings rogerhutchings commented Feb 24, 2017

Now requires the following statements to be true about a project before an owner can apply for beta:

  • Must have an active workflow
  • Must have all about pages filled in (doesn't check very hard, just to see how many pages are attached to a project; you can circumvent this by entering some content and deleting it again :/ )
  • Must have at least 100 subjects in active workflows see below

@mrniaboc

Review Checklist

Optional

  • If it's a new component, is it in ES6? Is it clear of warnings from ESLint?
  • Have you replaced any ChangeListener or PromiseRenderer components with code that updates component state?
  • If changes are made to the classifier, does the dev classifier still work?
  • Have you added in flow type annotations?

@mention-bot
Copy link

@rogerhutchings, thanks for your PR! By analyzing the history of the files in this pull request, we identified @srallen and @saschaishikawa to be potential reviewers.

@mschwamb
Copy link
Contributor

@rogerhutchings I wouldn't require all of the about pages to be filled if I read this correctly. Because on the about section is results that won't necessarily be filled out. None of my panoptes projects did I put content at launch, since those are supposed to be for news about results from then project.

Also for example there's an Education tab, we didn't make one for P4: Ridges because there's not really much a class could do with that project that we could think of so we skipped that page.

Can you just check the FAQ and the research are pages are filled out only? I think those are two that should be required, but everything else I think depending on the project could be optional.

@mschwamb
Copy link
Contributor

or maybe just count for 3 pages:about, faq, and team ( as team is autogenerated)?

@CKrawczyk
Copy link
Contributor

I just want to point out that this validation uses set_member_subjects_count for subject sets, and this counter is know to be wrong for some projects (zooniverse/panoptes#2155), so this PR should wait until that bug is fixed.

@rogerhutchings rogerhutchings changed the title Validate project before allowing beta application Validate project before allowing beta application - BLOCKED Feb 27, 2017
@rogerhutchings
Copy link
Contributor Author

@mschwamb Fair enough on Results, I'll change it to require two pages called "Research" and "FAQ". "Team" isn't actually autogenerated as a page, only the list of collaborators; there's also a page resource called Team that goes with it.

@CKrawczyk Good catch - I can separate this into two PRs so we can get the other validations in now.

@rogerhutchings
Copy link
Contributor Author

Okay, this now checks explicitly for the Research and FAQ changes, and no longer checks the number of active subjects - that's been moved to #3525. This should now be ready for review.

cc @mrniaboc

@rogerhutchings rogerhutchings changed the title Validate project before allowing beta application - BLOCKED Validate project before allowing beta application Feb 27, 2017
@rogerhutchings
Copy link
Contributor Author

Having spoken to @camallen, he reckons not to let the Panoptes issue stop this PR, so I'm closing in favour of #3525

@rogerhutchings rogerhutchings deleted the validate-project branch February 28, 2017 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants