Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test samples on Windows #85

Merged
merged 1 commit into from
Aug 12, 2020
Merged

Test samples on Windows #85

merged 1 commit into from
Aug 12, 2020

Conversation

torbsorb
Copy link
Contributor

Resolves #82

See #84 for future work.

trym-b
trym-b previously approved these changes Jul 15, 2020
Copy link
Contributor

@trym-b trym-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for fixing this.

The pylint complains about an unused module

@trym-b
Copy link
Contributor

trym-b commented Jul 15, 2020

You might want to add a line or two in the commit message of what the original issue was

@torbsorb torbsorb force-pushed the test-samples-on-windows branch from 7804b6f to e11a1be Compare July 15, 2020 10:55
Resolves #82

Add samples that depend on physical camera
@torbsorb torbsorb force-pushed the test-samples-on-windows branch from e11a1be to 15ceafb Compare July 19, 2020 14:05
@nedrebo nedrebo mentioned this pull request Jul 20, 2020
@torbsorb torbsorb merged commit 3495e98 into master Aug 12, 2020
@torbsorb torbsorb deleted the test-samples-on-windows branch August 12, 2020 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Investigate why running samples fails on windows
2 participants