Samples: Fix issues in ZividBenchmark #268
Merged
+189
−138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csu-bot-zivid
force-pushed
the
2024-12-13-update-cpp-samples
branch
from
e0a1201 to
a0e7805
Compare
There was some incorrect usage of the new combined settings object. In addition to explicitly calling capture2D and capture3D, we explicitly call the settings by a more descriptive name. Finally, a few minor spell checks.
SatjaSivcev
force-pushed
the
2024-12-13-update-cpp-samples
branch
from
a0e7805 to
33d7eba
Compare
SatjaSivcev
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was some incorrect usage of the new combined settings object.
In addition to explicitly calling capture2D and capture3D, we
explicitly call the settings by a more descriptive name.
Finally, a few minor spell checks.