Allow device cluster entities overwrite from v2 quirks #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmulcahey
reviewed
Dec 15, 2024
| @@ -314,7 +314,7 @@ def discover_quirks_v2_entities(self, device: Device) -> None: | |||
| endpoint.async_new_entity( | |||
| platform=platform, | |||
| entity_class=entity_class, | |||
| unique_id=endpoint.unique_id, | |||
| unique_id=f"{endpoint.unique_id}-{cluster.cluster_id}", | |||
There was a problem hiding this comment.
I think this will break all existing v2 entities and it will require a migration of the HA entity registry.
There was a problem hiding this comment.
Is that migration a post-install operation?
dmulcahey
reviewed
Dec 15, 2024
| (self.PLATFORM, self.unique_id), | ||
| self._device.platform_entities[(self.PLATFORM, self.unique_id)], | ||
| self, |
There was a problem hiding this comment.
Intention was to offer a debugging message for those cases where it is not intended or expected to encounter duplicated entities. Can be removed or demoted to debug.
dmulcahey
reviewed
Dec 15, 2024
| ) | ||
| self._device.platform_entities[(self.PLATFORM, self.unique_id)] = self |
There was a problem hiding this comment.
It is allowing a newer entity instance to overwrite an existing one. In my specific case, an automatic zha created local temp calibration entity would be replaced by one provided by a quirk v2. At least, in my setup, the quirk v2 entity gets created last.
TheJulianJES
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Entities created by a v2 quirk should be allowed to overwrite any default generated ones.
Current patch allows all overwrites and I'm not fully aware of the possible consequences outside the above mentioned use case.
Fixes home-assistant/core#128253.