Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure local temperature calibration range for Bosch thermostats #329

Merged

Conversation

mrrstux
Copy link
Contributor

@mrrstux mrrstux commented Dec 16, 2024

Applies to Bosch Zigbee thermostats models:

  • RBSH-RTH0-ZB-EU
  • RBSH-TRV0-ZB-EU
  • RBSH-TRV1-ZB-EU
  • RBSH-RTH0-BAT-ZB-EU

Workaround until (if ever) the general solution #328 gets adopted.

Fixes home-assistant/core#128253 for Bosch Zigbee thermostats.

Required by zigpy/zha-device-handlers#2808

@TheJulianJES TheJulianJES changed the title Configure local temperature calibration range for Bosch thermostats. Configure local temperature calibration range for Bosch thermostats Dec 18, 2024
@TheJulianJES TheJulianJES added the entities Issue or PR about (custom) entities label Dec 18, 2024
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.50%. Comparing base (c013c5b) to head (82290f8).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #329   +/-   ##
=======================================
  Coverage   96.49%   96.50%           
=======================================
  Files          61       61           
  Lines        9426     9431    +5     
=======================================
+ Hits         9096     9101    +5     
  Misses        330      330           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@TheJulianJES TheJulianJES left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This is good for now, as we already do the same for Sonoff TRVs.

@TheJulianJES TheJulianJES merged commit a0040c8 into zigpy:dev Dec 22, 2024
9 checks passed
@mrrstux mrrstux deleted the add-bosch-localtemp-calibration-overrides branch December 22, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
entities Issue or PR about (custom) entities
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Temperature calibration range limited to -2.5..2.5°
2 participants