Use fixed width types #1806
Merged
Use fixed width types #1806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepone
reviewed
Feb 19, 2024
pepone
approved these changes
Feb 19, 2024
bernardnormier
approved these changes
Feb 19, 2024
cpp/include/Ice/StreamHelpers.h
Outdated
| @@ -189,7 +189,7 @@ struct StreamableTraits<bool> | |||
| * \headerfile Ice/Ice.h | |||
| */ | |||
| template<> | |||
| struct StreamableTraits<Byte> | |||
| struct StreamableTraits<uint8_t> | |||
There was a problem hiding this comment.
Missing std:: for all fixed-size integers in this file.
InsertCreativityHere
pushed a commit
to InsertCreativityHere/compiler-comparison
that referenced
this pull request
Jan 1, 2025
…1806) - Update the generated code to use fixed width types (std::XXX_t) types - Remove Ice::Long / long long int
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the first step in implementing #1787. It does the following:
XXX_t) typesIce::Long/long long intand replace them byint64_t. This was the only type that was not compatible across all compilers.In follow-up PR(s) I plan to: