-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider switching to use _t types. #1787
Comments
We should check how compatible this proposed change here with the CI platforms. |
Did a preliminary test on macOS. Updated the compiler to generate these types and changed nothing else. Going to test MSVC and GCC next. |
So, macOS and Windows work, however Ubuntu's GCC typedefs int64_t to So while this is not a backward compatible change I think it's still a change worth making. Yes, users that are upgrading will have to make some changes. I think that's fine as it will bring us more inline with what modern C++ code should look like, as I think these type are the expected norm now. https://google.github.io/styleguide/cppguide.html#Integer_Types |
I agree on updating this to use _t types.
I assume they would use |
This was done in #1806 |
In the end we only did with fixed with types, so we did not use |
I think we should consider switch our numeric types to use
_t
types (Is there a better name for these?).typedef unsigned char Byte
uint8_t
typedef short Short;
int16_t
typedef int Int;
int32_t
typedef long long int Long;
int64_t
typedef float Float;
float_t
typedef double Double;
double_t
The text was updated successfully, but these errors were encountered: