Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding my animation to the project #2892

Merged
merged 7 commits into from
Dec 11, 2024
Merged

adding my animation to the project #2892

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5fdb5c9
adding my animation to the project
Anorme Nov 25, 2024
dc4d484
addressed feedbacks
Anorme Nov 26, 2024
9a00ec6
Changed title
Anorme Dec 2, 2024
af1a509
Delete changes file
Anorme Dec 2, 2024
5922f69
Fixed the link href
Anorme Dec 11, 2024
d3c97e3
get latest files Merge branch 'loading' of github.com:Anorme/Animatio…
Anorme Dec 11, 2024
f9cdc11
Merge branch 'master' into loading
LaurelineP Dec 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions Art/anorme-loading/index.html
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inccorrect link css file ref

  • must be styles.css and not style.css
    ( you will need to update the name of your css file )

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello and thanks for the correction I have amended the css name now

Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
<!DOCTYPE html>
<html>
<head>
<meta charset="utf-8">
<meta name="viewport" content="width=device-width, initial-scale=1">
<title>animation nation challenge</title>
<link rel="stylesheet" type="text/css" href="style.css">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect CSS filesheet

After changing the file name you need to adjust the link href

</head>

<body>
<h1> Loading . . . <h1>

<div class="wrapper">
<div id="box-1"></div>
<div id="box-2"></div>
<div id="box-3"></div>
</div>

</body>
</html>
Binary file added Art/anorme-loading/loading.gif
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unecessary gif

Please remove the file - a generated icon will be created on merge

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the gif has also been removed

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 4 additions & 0 deletions Art/anorme-loading/meta.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
{
"artName": "loading",
"githubHandle": "anorme"
}
93 changes: 93 additions & 0 deletions Art/anorme-loading/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,93 @@
:root {
--color1: pink;
--color2: beige;
--color3: lightcyan;
}
p {
margin: 0px;
}

h1 {
text-align: center;
height: 20px;
margin: 20px auto;
color:lightsteelblue;
}

.wrapper {
display: flex;
margin:40px auto ;
background-color: lightslategray;
position: relative;
/* top: 200px;*/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented style

Please remove the commented lines

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed the commented code as well. Do I need to submit another separate PR? or should I just commit and push upstream?

height: 200px;
justify-content: center;
align-items: center;


}

#box-1, #box-2, #box-3 {
width: 100px;
height: 100px;
margin: 20px auto;
line-height:100px;
text-align: center;
animation-duration: 4s;
animation-direction: reverse;
animation-iteration-count: infinite;

}

#box-1 {
background-color: pink;
animation-name: change-color1;
}

#box-2 {
background-color: beige;
animation-name: change-color2;

}

#box-3 {
background-color: lightcyan;
animation-name: change-color3;

}

@keyframes change-color1 {
0% {background-color: var(--color1);
transform: scale(1.0);}
25% {background-color: var(--color2);
transform: scale(1.0);}
50% {background-color: var(--color3);
transform: scale(1.0);}
75% {background-color: var(--color1);
transform: scale(1.2);}
100% {transform: scale(1.0);}
}

@keyframes change-color2 {
0% {background-color: var(--color2);
transform: scale(1.0);}
25% {background-color: var(--color3);
transform: scale(1.0);}
50% {background-color: var(--color1);
transform: scale(1.2);}
75% {background-color: var(--color2);
transform: scale(1.0);}
100% {transform: scale(1.0);}
}

@keyframes change-color3 {
0% {background-color: var(--color3);
transform: scale(1.0)}
25% {background-color: var(--color1);
transform: scale(1.2);}
50% {background-color: var(--color2);
transform: scale(1.0)}
75% {background-color: var(--color3);
transform: scale(1.0)}
100% {transform: scale(1.0)}
}