adding my animation to the project #2892
Conversation
|
🙏 Thanks for your pull request @Anorme, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
9 similar comments
|
🙏 Thanks for your pull request @Anorme, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
|
🙏 Thanks for your pull request @Anorme, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
|
🙏 Thanks for your pull request @Anorme, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
|
🙏 Thanks for your pull request @Anorme, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
|
🙏 Thanks for your pull request @Anorme, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
|
🙏 Thanks for your pull request @Anorme, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
|
🙏 Thanks for your pull request @Anorme, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
|
🙏 Thanks for your pull request @Anorme, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
|
🙏 Thanks for your pull request @Anorme, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
There was a problem hiding this comment.
Aloha and thanks for your contribution, @Anorme
Please address the feedbacks before we could merge your pull requests :)
There was a problem hiding this comment.
Inccorrect link css file ref
- must be styles.css and not style.css
( you will need to update the name of your css file )
There was a problem hiding this comment.
Hello and thanks for the correction I have amended the css name now
Art/anorme-loading/loading.gif
Outdated
There was a problem hiding this comment.
Unecessary gif
Please remove the file - a generated icon will be created on merge
There was a problem hiding this comment.
the gif has also been removed
Art/anorme-loading/style.css
Outdated
| margin:40px auto ; | ||
| background-color: lightslategray; | ||
| position: relative; | ||
| /* top: 200px;*/ |
There was a problem hiding this comment.
Commented style
Please remove the commented lines
There was a problem hiding this comment.
I've removed the commented code as well. Do I need to submit another separate PR? or should I just commit and push upstream?
|
🙏 Thanks for your pull request @Anorme, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
|
🙏 Thanks for your pull request @Anorme, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
|
🙏 Thanks for your pull request @Anorme, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
1 similar comment
|
🙏 Thanks for your pull request @Anorme, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
|
Hi there @Anorme , your feedback are not addressed as you can see on the github changes : you added an unecessary changes file that should also be removed. |
|
I don't know how that changes file got there, it's not even in my local files. I'm going to try committing again though. |
|
🙏 Thanks for your pull request @Anorme, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
|
🙏 Thanks for your pull request @Anorme, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
Art/anorme-loading/index.html
Outdated
| <meta charset="utf-8"> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1"> | ||
| <title>Animation Nation challenge</title> | ||
| <link rel="stylesheet" type="text/css" href="style.css"> |
There was a problem hiding this comment.
Incorrect CSS filesheet
After changing the file name you need to adjust the link href
|
🙏 Thanks for your pull request @Anorme, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
1 similar comment
|
🙏 Thanks for your pull request @Anorme, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
…n-Nation into loading
|
🙏 Thanks for your pull request @Anorme, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
|
🙏 Thanks for your pull request @Anorme, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
Thank you for making a pull request to ZTM's Animation Nation project. We will review your pull request as soon as we can, but keep in mind we can get very busy during Hacktoberfest.
While you're waiting, please look over this checklist. Feel free to write a description of what you did as well!
What I did
Optional: Edit this to tell us what you did!
Pull request checklist
meta.jsonfile.<github_username>-<art_name>without the <>.index.htmlandstyles.css.index.htmlstyles.cssmeta.jsonwith:githubHandle: being your unique github user name,artName: name of your animationNot normally needed
Note: if your pull request makes an improvement besides adding a CSS animation you will need to discuss this with the maintainers. You can help kickstart this process by explaining what your change does and why you are making it in the "What I did" section
What to expect