Bluetooth: Controller: Fix ISO Tx PDU buffer counts for fragmentation #82026
+24
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: Bluetooth HCI
Thalley
reviewed
Nov 26, 2024
Comment on lines
-1007
to
-1013
| config BT_CTLR_CONN_ISO_SDU_LEN_MAX | ||
| int "Maximum Connected Isochronous Channel SDU Length" | ||
| depends on BT_CTLR_CONN_ISO | ||
| range 1 4095 | ||
| default 251 | ||
| help | ||
| Maximum Connected Isochronous Channel SDU Length. |
There was a problem hiding this comment.
Do we need to go through the deprecation process for this?
There was a problem hiding this comment.
ISO is experimental upstream. And not sure if any downstream implementation use this.
There was a problem hiding this comment.
Ideally we would select EXPERIMENTAL for all experiment controller Kconfigs as well then
Fix ISO Tx PDU buffer count required when SDUs fragmentation is used. Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
Remove unused BT_CTLR_CONN_ISO_SDU_LEN_MAX, required Tx PDU buffer counts are now calculated using ISO Tx Buffer size. Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
cvinayak
force-pushed
the
github_iso_tx_buffer_count_fix
branch
from
3877e1c
to
6707b39
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix ISO Tx PDU buffer count required when SDUs fragmentation is used.