Skip to content

Commit

Permalink
Bluetooth: Controller: Remove BT_CTLR_CONN_ISO_SDU_LEN_MAX
Browse files Browse the repository at this point in the history 
Remove unused BT_CTLR_CONN_ISO_SDU_LEN_MAX, required Tx PDU
buffer counts are now calculated using ISO Tx Buffer size.

Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
  • Loading branch information
@cvinayak
cvinayak committed Nov 26, 2024
1 parent 1cbdbbc commit 3877e1c
Show file tree
Hide file tree
Showing 11 changed files with 1 addition and 19 deletions.
1 change: 0 additions & 1 deletion samples/bluetooth/hci_ipc/nrf5340_cpunet_cis-bt_ll_sw_split.conf
View file
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,6 @@ CONFIG_BT_CTLR_PERIPHERAL_ISO=y
CONFIG_BT_CTLR_CONN_ISO_GROUPS=1
CONFIG_BT_CTLR_CONN_ISO_STREAMS=2
CONFIG_BT_CTLR_CONN_ISO_STREAMS_PER_GROUP=2
CONFIG_BT_CTLR_CONN_ISO_SDU_LEN_MAX=247
CONFIG_BT_CTLR_CONN_ISO_PDU_LEN_MAX=251
CONFIG_BT_CTLR_CONN_ISO_LOW_LATENCY_POLICY=y

Expand Down
1 change: 0 additions & 1 deletion samples/bluetooth/hci_ipc/nrf5340_cpunet_iso-bt_ll_sw_split.conf
View file
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,6 @@ CONFIG_BT_CTLR_PERIPHERAL_ISO=y
CONFIG_BT_CTLR_CONN_ISO_GROUPS=1
CONFIG_BT_CTLR_CONN_ISO_STREAMS=2
CONFIG_BT_CTLR_CONN_ISO_STREAMS_PER_GROUP=2
CONFIG_BT_CTLR_CONN_ISO_SDU_LEN_MAX=247
CONFIG_BT_CTLR_CONN_ISO_PDU_LEN_MAX=251
CONFIG_BT_CTLR_CONN_ISO_LOW_LATENCY_POLICY=y

Expand Down
1 change: 0 additions & 1 deletion samples/bluetooth/hci_ipc/nrf5340_cpunet_iso_central-bt_ll_sw_split.conf
View file
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@ CONFIG_BT_CTLR_PERIPHERAL_ISO=n
CONFIG_BT_CTLR_CONN_ISO_GROUPS=1
CONFIG_BT_CTLR_CONN_ISO_STREAMS=2
CONFIG_BT_CTLR_CONN_ISO_STREAMS_PER_GROUP=2
CONFIG_BT_CTLR_CONN_ISO_SDU_LEN_MAX=247
CONFIG_BT_CTLR_CONN_ISO_PDU_LEN_MAX=251
CONFIG_BT_CTLR_CONN_ISO_LOW_LATENCY_POLICY=y

Expand Down
1 change: 0 additions & 1 deletion samples/bluetooth/hci_ipc/nrf5340_cpunet_iso_peripheral-bt_ll_sw_split.conf
View file
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@ CONFIG_BT_CTLR_PERIPHERAL_ISO=y
CONFIG_BT_CTLR_CONN_ISO_GROUPS=1
CONFIG_BT_CTLR_CONN_ISO_STREAMS=2
CONFIG_BT_CTLR_CONN_ISO_STREAMS_PER_GROUP=2
CONFIG_BT_CTLR_CONN_ISO_SDU_LEN_MAX=247
CONFIG_BT_CTLR_CONN_ISO_PDU_LEN_MAX=251
CONFIG_BT_CTLR_CONN_ISO_LOW_LATENCY_POLICY=y

Expand Down
1 change: 0 additions & 1 deletion samples/bluetooth/hci_uart/overlay-all-bt_ll_sw_split.conf
View file
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,6 @@ CONFIG_BT_CTLR_PERIPHERAL_ISO=y
CONFIG_BT_CTLR_CONN_ISO_STREAMS=2
CONFIG_BT_CTLR_CONN_ISO_GROUPS=1
CONFIG_BT_CTLR_CONN_ISO_STREAMS_PER_GROUP=2
CONFIG_BT_CTLR_CONN_ISO_SDU_LEN_MAX=247
CONFIG_BT_CTLR_CONN_ISO_PDU_LEN_MAX=251
CONFIG_BT_CTLR_CONN_ISO_LOW_LATENCY_POLICY=y

Expand Down
1 change: 0 additions & 1 deletion samples/bluetooth/hci_uart_3wire/overlay-all-bt_ll_sw_split.conf
View file
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,6 @@ CONFIG_BT_CTLR_PERIPHERAL_ISO=y
CONFIG_BT_CTLR_CONN_ISO_STREAMS=2
CONFIG_BT_CTLR_CONN_ISO_GROUPS=1
CONFIG_BT_CTLR_CONN_ISO_STREAMS_PER_GROUP=2
CONFIG_BT_CTLR_CONN_ISO_SDU_LEN_MAX=247
CONFIG_BT_CTLR_CONN_ISO_PDU_LEN_MAX=251
CONFIG_BT_CTLR_CONN_ISO_LOW_LATENCY_POLICY=y

Expand Down
3 changes: 1 addition & 2 deletions samples/bluetooth/iso_central/overlay-bt_ll_sw_split.conf
View file
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,7 @@ CONFIG_BT_CTLR_SCAN_DATA_LEN_MAX=1650
# of PDUs
CONFIG_BT_CTLR_RX_BUFFERS=9

# Sufficient ISO SDU and PDU length for this sample with ISO_TX_MTU of 247
CONFIG_BT_CTLR_CONN_ISO_SDU_LEN_MAX=247
# Maximum PDU length for this sample with ISO_TX_MTU if set up to and over 247 bytes
CONFIG_BT_CTLR_CONN_ISO_PDU_LEN_MAX=251

# Number of supported streami sources and sinks
Expand Down
8 changes: 0 additions & 8 deletions subsys/bluetooth/controller/Kconfig
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1004,14 +1004,6 @@ config BT_CTLR_CONN_ISO_PDU_LEN_MAX
help
Maximum Connected Isochronous Channel PDU Length.

config BT_CTLR_CONN_ISO_SDU_LEN_MAX
int "Maximum Connected Isochronous Channel SDU Length"
depends on BT_CTLR_CONN_ISO
range 1 4095
default 251
help
Maximum Connected Isochronous Channel SDU Length.

config BT_CTLR_CONN_ISO_STREAMS_MAX_NSE
int "LE Connected Isochronous Streams max number of subevents"
depends on BT_CTLR_CONN_ISO
Expand Down
1 change: 0 additions & 1 deletion tests/bsim/bluetooth/audio/overlay-bt_ll_sw_split.conf
View file
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ CONFIG_BT_CTLR_CENTRAL_ISO=y
CONFIG_BT_CTLR_PERIPHERAL_ISO=y
CONFIG_BT_CTLR_CONN_ISO_STREAMS=2
CONFIG_BT_CTLR_CONN_ISO_STREAMS_PER_GROUP=2
CONFIG_BT_CTLR_CONN_ISO_SDU_LEN_MAX=247
CONFIG_BT_CTLR_CONN_ISO_PDU_LEN_MAX=251
CONFIG_BT_CTLR_CONN_ISO_LOW_LATENCY_POLICY=y

Expand Down
1 change: 0 additions & 1 deletion tests/bsim/bluetooth/ll/cis/prj.conf
View file
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ CONFIG_LOG=y
CONFIG_BT_LL_SW_SPLIT=y
CONFIG_BT_CTLR_CENTRAL_ISO=y
CONFIG_BT_CTLR_PERIPHERAL_ISO=y
CONFIG_BT_CTLR_CONN_ISO_SDU_LEN_MAX=247
CONFIG_BT_CTLR_CONN_ISO_PDU_LEN_MAX=251
CONFIG_BT_CTLR_CONN_ISO_STREAMS=9
CONFIG_BT_CTLR_CONN_ISO_STREAMS_PER_GROUP=9
Expand Down
1 change: 0 additions & 1 deletion ...s/bsim/bluetooth/ll/cis/sysbuild/hci_ipc/nrf5340_cpunet_iso_acl_group-bt_ll_sw_split.conf
View file
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,6 @@ CONFIG_BT_CTLR_SYNC_ISO_STREAM_MAX=2
# ISO Connection Oriented
CONFIG_BT_CTLR_CENTRAL_ISO=y
CONFIG_BT_CTLR_PERIPHERAL_ISO=y
CONFIG_BT_CTLR_CONN_ISO_SDU_LEN_MAX=247
CONFIG_BT_CTLR_CONN_ISO_PDU_LEN_MAX=251
CONFIG_BT_CTLR_CONN_ISO_STREAMS=4
CONFIG_BT_CTLR_CONN_ISO_STREAMS_PER_GROUP=4
Expand Down

0 comments on commit 3877e1c

Please sign in to comment.