doc: release: 4.0: Add Espressif changes #80912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sylvioalves
commented
Nov 5, 2024
doc/releases/release-notes-4.0.rst
Outdated
| @@ -220,6 +223,7 @@ Boards & SoC Support | |||
| * :zephyr:board:`WeAct Studio STM32F405 Core Board V1.0 <weact_stm32f405_core>` (``weact_stm32f405_core``) | |||
| * :zephyr:board:`WeAct Studio USB2CANFDV1 <usb2canfdv1>` (``usb2canfdv1``) | |||
| * :zephyr:board:`Witte Technology Linum Board <linum>` (``linum``) | |||
| * :zephyr:board:`Seeed XIAO ESP32-S3 Sense Variant <xiao_esp32s3>`: ``xiao_esp32s3``. | |||
There was a problem hiding this comment.
@kartben This is a variant. Let me know if this is the right place to do so.
There was a problem hiding this comment.
It's fine to add, and actually a good idea. Please just keep alphabetical order intact though, and consider indicating the full target name that includes the variant (it's a bit of a mouthful though:))
There was a problem hiding this comment.
@kartben How do I reference the variant in here? xiao_esp32s3_sense?
There was a problem hiding this comment.
xiao_esp32s3/esp32s3/procpu/sense
But maybe it's too long, like I said :)
zephyrbot
added
platform: ESP32
zephyrbot
requested review from
dkalowsk,
kartben,
LucasTambor,
marekmatej,
mmahadevan108,
raffarost,
uLipe and
wmrsouza
sylvioalves
removed request for
uLipe,
dkalowsk,
marekmatej,
mmahadevan108,
LucasTambor,
wmrsouza and
raffarost
sylvioalves
force-pushed
the
release_notes_v4_01
branch
from
d8f9b4f
to
a4792b0
Compare
zephyrbot
requested review from
dkalowsk,
LucasTambor,
mmahadevan108,
uLipe and
wmrsouza
kartben
requested changes
Nov 5, 2024
doc/releases/release-notes-4.0.rst
Outdated
| @@ -220,6 +223,7 @@ Boards & SoC Support | |||
| * :zephyr:board:`WeAct Studio STM32F405 Core Board V1.0 <weact_stm32f405_core>` (``weact_stm32f405_core``) | |||
| * :zephyr:board:`WeAct Studio USB2CANFDV1 <usb2canfdv1>` (``usb2canfdv1``) | |||
| * :zephyr:board:`Witte Technology Linum Board <linum>` (``linum``) | |||
| * :zephyr:board:`Seeed XIAO ESP32-S3 Sense Variant <xiao_esp32s3>`: ``xiao_esp32s3``. | |||
There was a problem hiding this comment.
It's fine to add, and actually a good idea. Please just keep alphabetical order intact though, and consider indicating the full target name that includes the variant (it's a bit of a mouthful though:))
sylvioalves
force-pushed
the
release_notes_v4_01
branch
2 times, most recently
from
a319e4b
to
419ea14
Compare
kartben
approved these changes
Nov 5, 2024
raffarost
previously approved these changes
Nov 5, 2024
wmrsouza
previously approved these changes
Nov 5, 2024
uLipe
previously approved these changes
Nov 5, 2024
sylvioalves
force-pushed
the
release_notes_v4_01
branch
from
419ea14
to
0c663ce
Compare
kartben
previously approved these changes
Nov 6, 2024
|
@kartben CI is failing in documentation. I rebased and pushed again to try fixing it. |
kartben
reviewed
Nov 6, 2024
sylvioalves
dismissed stale reviews from kartben, wmrsouza, raffarost, and uLipe
via
c77d124
sylvioalves
force-pushed
the
release_notes_v4_01
branch
from
0c663ce
to
c77d124
Compare
kartben
requested changes
Nov 6, 2024
Update board name to meet zephyr:board model. Signed-off-by: Sylvio Alves <[email protected]>
Fix typo and re-phrase help description to improve it. Signed-off-by: Sylvio Alves <[email protected]>
Adds notes on Espressif changes to this release. Signed-off-by: Sylvio Alves <[email protected]>
sylvioalves
force-pushed
the
release_notes_v4_01
branch
from
c77d124
to
0698e29
Compare
kartben
approved these changes
Nov 6, 2024
raffarost
approved these changes
Nov 6, 2024
wmrsouza
approved these changes
Nov 6, 2024
mmahadevan108
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds notes on Espressif changes to this release.