soc: xtensa: intel_adsp: cavs: fix assert on L3_MEM_BASE_ADDR #62180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The assert on L3_MEM_BASE_ADDR is incorrect, we need must convert to uncached before use. Fixes: ffd2121 ("soc: xtensa: intel_adsp: cavs: fix power_down_cavs() signature") Signed-off-by: Kai Vehmanen <[email protected]>
kv2019i
force-pushed
the
202308-fix-cavs-imrsetup-assert
branch
from
08c4af4 to
0275f27
Compare
|
Test results with SOF CI running at thesofproject/sof#8136 , looks good (previously failing tests are now passing), so marking as ready for review. |
kv2019i
added
priority: high
zephyrbot
requested review from
aborisovich,
ceolin,
jxstelter,
lgirdwood,
lyakh,
marc-hb,
marcinszkudlinski,
softwarecki and
tmleman
dcpleung
approved these changes
Aug 31, 2023
|
This is my bad, the assert is not correct. The test plans I ran for the faulty PR actually caught the failure, but I made a human error in parsing the test results. The test plan that failed has been flaky in recent weeks, but I did not spot the actual failure on cAVS2.5 targets, so this slipped through. |
|
Ok, all tests passed in thesofproject/sof#8136 and CI is good here as well, so this should be good to go. |
nashif
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The assert on L3_MEM_BASE_ADDR is incorrect, we need must convert to uncached before use.
Fixes: ffd2121 ("soc: xtensa: intel_adsp: cavs: fix power_down_cavs() signature")