ci: remove dependency on pull/43987/head to track zephyr main directly #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfriedt
force-pushed
the
issue/129/ci-remove-dependency-on-pull-43987-head-to-track-zephyr-main-directly
branch
from
b9cecc0
to
16a819b
Compare
This is a temporary workaround until the mountain of tech-debt is flattened w.r.t the following: zephyrproject-rtos/zephyr#43987 #62 zephyrproject-rtos/zephyr#43998 zephyrproject-rtos/zephyr#46910 zephyrproject-rtos/zephyr#45100 but also around the mountain of tech-debt as a result of poor arch/posix software architecture, CONFIG_ARCH_POSIX and CONFIG_POSIX_API incompatibility, and the resultant spillover of moving POSIX definitions into the network subsystem as a result. Fixes #129 Signed-off-by: Christopher Friedt <[email protected]>
cfriedt
force-pushed
the
issue/129/ci-remove-dependency-on-pull-43987-head-to-track-zephyr-main-directly
branch
from
16a819b
to
a545aee
Compare
|
@SdtElectronics - although this is good in the sense that it reduces the number of moving parts in our project, the main downside is that every time a posix header issue is found in |
SdtElectronics
approved these changes
Aug 11, 2022
stephanosio
approved these changes
Aug 11, 2022
cfriedt
deleted the
issue/129/ci-remove-dependency-on-pull-43987-head-to-track-zephyr-main-directly
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a temporary workaround due to the following:
zephyrproject-rtos/zephyr#43987
#62
zephyrproject-rtos/zephyr#43998
zephyrproject-rtos/zephyr#46910
zephyrproject-rtos/zephyr#45100
zephyrproject-rtos/zephyr#43987 is mainly an effort to remove the
<zephyr/posix/...>prefix required for standard includes (which improves portability).However, it has also highlighted the mountain of tech-debt that needs to be leveled as a result of poor arch/posix software architecture, CONFIG_ARCH_POSIX and CONFIG_POSIX_API incompatibility, and the resultant spillover of moving POSIX definitions into the network subsystem.
Fixes #129