Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes required for keystone support that require dependency updates beyond what we can currently do. #1666

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from

Merge branch 'zcash_keys_no_std' into keystone_no_std

ab80376
Select commit
Loading
Failed to load commit list.
Draft

Changes required for keystone support that require dependency updates beyond what we can currently do. #1666

Merge branch 'zcash_keys_no_std' into keystone_no_std
ab80376
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Dec 17, 2024 in 1s

52.93% (-0.02%) compared to a1e4e7a

View this Pull Request on Codecov

52.93% (-0.02%) compared to a1e4e7a

Details

Codecov Report

Attention: Patch coverage is 10.93750% with 57 lines in your changes missing coverage. Please review.

Project coverage is 52.93%. Comparing base (a1e4e7a) to head (ab80376).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
pczt/src/common.rs 0.00% 27 Missing ⚠️
pczt/src/roles/low_level_signer/mod.rs 0.00% 24 Missing ⚠️
devtools/src/bin/inspect/transaction.rs 0.00% 2 Missing ⚠️
zcash_transparent/src/builder.rs 0.00% 2 Missing ⚠️
zcash_transparent/src/keys.rs 87.50% 1 Missing ⚠️
zcash_transparent/src/pczt/signer.rs 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1666      +/-   ##
==========================================
- Coverage   52.94%   52.93%   -0.02%     
==========================================
  Files         175      176       +1     
  Lines       21072    21104      +32     
==========================================
+ Hits        11157    11171      +14     
- Misses       9915     9933      +18

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov