Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes required for keystone support that require dependency updates beyond what we can currently do. #1666

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from

Merge branch 'zcash_keys_no_std' into keystone_no_std

ab80376
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Draft

Changes required for keystone support that require dependency updates beyond what we can currently do. #1666

Merge branch 'zcash_keys_no_std' into keystone_no_std
ab80376
Select commit
Loading
Failed to load commit list.
GitHub Actions / Clippy (MSRV) failed Dec 17, 2024 in 0s

Clippy (MSRV)

1 error

Details

Results

Message level Amount
Internal compiler error 0
Error 1
Warning 0
Note 0
Help 0

Versions

  • rustc 1.77.0 (aedd173a2 2024-03-17)
  • cargo 1.77.0 (3fe68eabf 2024-02-29)
  • clippy 0.1.77 (aedd173 2024-03-17)

Annotations

Check failure on line 217 in pczt/src/common.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (MSRV)

this returns a `Result<_, ()>`

error: this returns a `Result<_, ()>`
   --> pczt/src/common.rs:214:1
    |
214 | / pub fn determine_lock_time<L: LockTimeInput>(
215 | |     global: &crate::common::Global,
216 | |     inputs: &[L],
217 | | ) -> Result<u32, ()> {
    | |____________________^
    |
    = help: use a custom `Error` type instead
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_unit_err
    = note: `-D clippy::result-unit-err` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::result_unit_err)]`