-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add unit tests #72
Conversation
…om/zavolanlab/mirflowz into 52-unit-tests-filter_multimapperpy Merge to be able to pull
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I'm really sorry @deliaBlue. I had reviewed this on Saturday, and was wondering why you didn't respond. But now I've seen that I hadn't actually submitted the review. Sorry about that 🙈
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See individual comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for adding a whole bunch of new comments 🙈
Regarding the token option you mention here, If you open the codecov link in the CI, you will see the warning
I thought that maybe adding the token it would fix this; it did not. I'll take a look at it later. |
filter_multimapper.py
filter_multimapper.py
But did you actually try without a token? Whenever I saw this the token was there. The thing is that I think the tokens are scoped to each repository, so you can't use an organization-scoped CodeCov token. And indeed, such a token is not defined: So I suggest that you first try without a token, and if/when it turns out that we really need a token, I will create one on CodeCov and set it here as a repository secret (I don't think that you have the permissions to do that, but you can try). |
I try it without the token and still obtain the same. |
I'll proceed on deleting the coverage call. This issue can be addressed in #74 . |
filter_multimapper.py
Closes #52
In order to add a test for
filter_multimappers.py
the following changes had been made:count_indels
andfind_best_alignments
callsenvironment.yml
andenvironment.dev.yml
CI.yml