Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: extend mature miRNA annotations #73

Merged
merged 64 commits into from
May 2, 2023
Merged

feat: extend mature miRNA annotations #73

merged 64 commits into from
May 2, 2023

Conversation

deliaBlue
Copy link
Collaborator

Closes #65

In this PR the changes applied are:

  • Creation of a class that extends mature miRNA coordinates
  • Implement a script that uses the class
  • Create unit tests for both the class and the script
  • Update dev dependencies to include gffutils and the pytest and coverage

@deliaBlue deliaBlue requested a review from uniqueg April 27, 2023 09:59
@deliaBlue deliaBlue linked an issue Apr 27, 2023 that may be closed by this pull request
scripts/mirna_extension.py Outdated Show resolved Hide resolved
scripts/mirna_extension.py Outdated Show resolved Hide resolved
scripts/mirna_extension.py Outdated Show resolved Hide resolved
scripts/mirna_extension.py Show resolved Hide resolved
try/collapse_sam_by_seq.py Outdated Show resolved Hide resolved
workflow/rules/prepare.smk Outdated Show resolved Hide resolved
test/expected_output.md5 Outdated Show resolved Hide resolved
scripts/mirna_extension.py Outdated Show resolved Hide resolved
Copy link
Member

@uniqueg uniqueg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting there. 3 more minor comments, I think after we can merge :)

scripts/mirna_extension.py Outdated Show resolved Hide resolved
scripts/mirna_extension.py Outdated Show resolved Hide resolved
scripts/mirna_extension.py Outdated Show resolved Hide resolved
@deliaBlue
Copy link
Collaborator Author

deliaBlue commented May 2, 2023

If I am not wrong, we said that the extension would be for the user to define; provide this option on the config file has not yet been implemented. Do you still want the extension to be for the user to change or you rather leave it at 6 by the moment?

@uniqueg
Copy link
Member

uniqueg commented May 2, 2023

If I am not wrong, we said that the extension would be for the user to define; provide this option on the config file has not yet been implemented. Do you still want the extension to be for the user to change or you rather leave it at 6 by the moment?

Yes, it should indeed by up for the user, good that you remembered. Please add it to the config file; this PR is the right place to do this. Rest looks good now.

@deliaBlue
Copy link
Collaborator Author

deliaBlue commented May 2, 2023

While adding the extension option I saw that config_schema.json and config_template.yaml are outdated. They need to have removed the "isomiRs generation parameters" and in case of the template, it need to have the addition of the extension parameter. Can I do a simple PR named "build: update config files" and do these two changes?

@uniqueg uniqueg merged commit 9faac85 into dev May 2, 2023
@uniqueg uniqueg deleted the 65-extend-mirna branch May 2, 2023 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend miRNA n nucleotides.
3 participants