Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: render tables and yaml on stdout #3226

Merged
merged 12 commits into from
Dec 5, 2024
Merged

Conversation

mkcp
Copy link
Contributor

@mkcp mkcp commented Nov 8, 2024

Description

This PR introduces a TableWithWriter function, changes Table prints to use stdout, and changes common.ColorPrintYaml to use stdout.

Related Issue

Finishes #3223
Relates to #2576

Checklist before merging

@mkcp mkcp added the bug 🐞 Something isn't working label Nov 8, 2024
@mkcp mkcp self-assigned this Nov 8, 2024
@mkcp mkcp requested review from a team as code owners November 8, 2024 23:32
Copy link

netlify bot commented Nov 8, 2024

Deploy Preview for zarf-docs ready!

Name Link
🔨 Latest commit 54206ee
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/6751f6b7cbd81200087cc3c9
😎 Deploy Preview https://deploy-preview-3226--zarf-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/pkg/message/message.go 0.00% 7 Missing ⚠️
src/pkg/utils/yaml.go 0.00% 2 Missing ⚠️
src/cmd/common/table.go 0.00% 1 Missing ⚠️
src/cmd/package.go 0.00% 1 Missing ⚠️
src/pkg/message/connect.go 0.00% 1 Missing ⚠️
src/pkg/message/credentials.go 0.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
src/cmd/connect.go 0.00% <ø> (ø)
src/cmd/dev.go 0.00% <ø> (ø)
src/cmd/root.go 0.00% <ø> (ø)
src/cmd/common/table.go 0.00% <0.00%> (ø)
src/cmd/package.go 0.00% <0.00%> (ø)
src/pkg/message/connect.go 0.00% <0.00%> (ø)
src/pkg/message/credentials.go 0.00% <0.00%> (ø)
src/pkg/utils/yaml.go 0.00% <0.00%> (ø)
src/pkg/message/message.go 11.32% <0.00%> (-0.45%) ⬇️

@mkcp
Copy link
Contributor Author

mkcp commented Nov 12, 2024

Hold off on review or merge, I need to look over the failing e2e tests.

@mkcp mkcp mentioned this pull request Nov 12, 2024
20 tasks
@mkcp
Copy link
Contributor Author

mkcp commented Nov 19, 2024

reworking this approach, we shouldn't have to update globals

@mkcp mkcp force-pushed the mkcp/tables-to-out branch from 40d31f0 to dbe02e9 Compare November 21, 2024 18:51
@mkcp
Copy link
Contributor Author

mkcp commented Nov 21, 2024

Much better now - just chasing down failing tests.

@mkcp mkcp changed the title feat: render tables on stdout feat: render tables and yaml on stdout Dec 5, 2024
@AustinAbro321 AustinAbro321 added this pull request to the merge queue Dec 5, 2024
Merged via the queue into main with commit c979349 Dec 5, 2024
27 checks passed
@AustinAbro321 AustinAbro321 deleted the mkcp/tables-to-out branch December 5, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐞 Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants