-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: render tables and yaml on stdout #3226
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for zarf-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
|
Hold off on review or merge, I need to look over the failing e2e tests. |
reworking this approach, we shouldn't have to update globals |
Signed-off-by: Kit Patella <[email protected]>
Signed-off-by: Kit Patella <[email protected]>
Signed-off-by: Kit Patella <[email protected]>
…with writers instead Signed-off-by: Kit Patella <[email protected]>
mkcp
force-pushed
the
mkcp/tables-to-out
branch
from
November 21, 2024 18:51
40d31f0
to
dbe02e9
Compare
Signed-off-by: Kit Patella <[email protected]>
… ref now Signed-off-by: Kit Patella <[email protected]>
Much better now - just chasing down failing tests. |
Signed-off-by: Kit Patella <[email protected]>
mkcp
changed the title
feat: render tables on stdout
feat: render tables and yaml on stdout
Dec 5, 2024
Signed-off-by: Kit Patella <[email protected]>
Signed-off-by: Kit Patella <[email protected]>
Signed-off-by: Kit Patella <[email protected]>
AustinAbro321
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a
TableWithWriter
function, changes Table prints to use stdout, and changes common.ColorPrintYaml to use stdout.Related Issue
Finishes #3223
Relates to #2576
Checklist before merging