You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
This is rly more of a bug that I started doing while I was adding in structured logs. Tables needed to be reinitialized when pterm is feature flagged off -- when I put this hack together I passed them logger.DefaultDestination which happens to be stderr.
Describe the behavior you'd like
Sending tables that are definitely "output for users" to stderr isn't very unixy, so let's instead send them to stdout. Let's also declare the writer outside of logger. These are similar but not the same components, so there's no need to use a logger type for output.
Most if not all of of these table prints are well contained to the cmd layer. Here's some examples, this should not be considered an exhaustive list:
Is your feature request related to a problem? Please describe.
This is rly more of a bug that I started doing while I was adding in structured logs. Tables needed to be reinitialized when pterm is feature flagged off -- when I put this hack together I passed them
logger.DefaultDestination
which happens to be stderr.Describe the behavior you'd like
Sending tables that are definitely "output for users" to stderr isn't very unixy, so let's instead send them to stdout. Let's also declare the writer outside of logger. These are similar but not the same components, so there's no need to use a logger type for output.
Most if not all of of these table prints are well contained to the cmd layer. Here's some examples, this should not be considered an exhaustive list:
zarf/src/cmd/dev.go
Line 266 in 36b779f
zarf/src/cmd/dev.go
Line 317 in 36b779f
zarf/src/cmd/package.go
Line 240 in 36b779f
zarf/src/cmd/package.go
Line 286 in 36b779f
Additional context
Ideally we don't have to use this re-initialize hack at all, but that may have to be in scope for a future issue.
The text was updated successfully, but these errors were encountered: