Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send PTerm tables to os.Stdout not logger.DefaultDestination #3223

Closed
mkcp opened this issue Nov 8, 2024 · 1 comment
Closed

Send PTerm tables to os.Stdout not logger.DefaultDestination #3223

mkcp opened this issue Nov 8, 2024 · 1 comment
Assignees
Labels
bug 🐞 Something isn't working
Milestone

Comments

@mkcp
Copy link
Contributor

mkcp commented Nov 8, 2024

Is your feature request related to a problem? Please describe.

This is rly more of a bug that I started doing while I was adding in structured logs. Tables needed to be reinitialized when pterm is feature flagged off -- when I put this hack together I passed them logger.DefaultDestination which happens to be stderr.

Describe the behavior you'd like

Sending tables that are definitely "output for users" to stderr isn't very unixy, so let's instead send them to stdout. Let's also declare the writer outside of logger. These are similar but not the same components, so there's no need to use a logger type for output.

Most if not all of of these table prints are well contained to the cmd layer. Here's some examples, this should not be considered an exhaustive list:

Additional context

Ideally we don't have to use this re-initialize hack at all, but that may have to be in scope for a future issue.

@mkcp mkcp added the bug 🐞 Something isn't working label Nov 8, 2024
@mkcp mkcp added this to Zarf Nov 8, 2024
@github-project-automation github-project-automation bot moved this to Triage in Zarf Nov 8, 2024
@mkcp mkcp mentioned this issue Nov 8, 2024
4 tasks
@mkcp mkcp self-assigned this Nov 8, 2024
@mkcp mkcp moved this from Triage to In progress in Zarf Nov 21, 2024
@mkcp mkcp moved this from In progress to In review in Zarf Dec 5, 2024
@mkcp mkcp added this to the v0.44.0 milestone Dec 5, 2024
@AustinAbro321
Copy link
Contributor

Fixed by #3226

@github-project-automation github-project-automation bot moved this from In review to Done in Zarf Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐞 Something isn't working
Projects
Status: Done
Development

No branches or pull requests

2 participants