Code

feat: add linter (2949)#3053

Code

Merged

mkcp merged 61 commits intomainzarf-dev/zarf:mainfrom mkcp/2949-add-linterzarf-dev/zarf:mkcp/2949-add-linterCopy head branch name to clipboardOct 3, 2024

+28-18

Commits

Commits on Sep 25, 2024

• add errcheck linting

  Show description for 358dd41
  mkcp

  committed
  358dd41

• linter ignore some intentionally unhandled errs

  Show description for 655dd76
  mkcp

  committed
  655dd76

• handle some env var set and unset errors in tests

  Show description for cce62ce
  mkcp

  committed
  cce62ce

• make some notes in cmd/destroy.go for later

  Show description for ae05ebb
  mkcp

  committed
  ae05ebb

• direct handle some deferred cleanups to add direct error handling

  Show description for 992aa3c
  mkcp

  committed
  992aa3c

• capture errors from cmd/root

  Show description for 81e54f7
  mkcp

  committed
  81e54f7

• capture errors on src/config/config.go. checking ci

  Show description for 9b2b2e9
  mkcp

  committed
  9b2b2e9

• fix: ensure we capture and propagate errors in src/internal

  Show description for a508aa7
  mkcp

  committed
  a508aa7

• fix: propagate or log unhandled errors in src/cmd

  Show description for 6f53a29
  mkcp

  committed
  6f53a29

• fix: check for or intentionally ignore some dangling errors in tests

  Show description for 4283faf
  mkcp

  committed
  4283faf

• fix: use RemoveAll not remove so it doesnt error every time

  Show description for cd5fdc7
  mkcp

  committed
  cd5fdc7

• fix: disabling the err catch to see if it's something i changed

  Show description for 9059544
  mkcp

  committed
  9059544

• fix: should fix the directory not empty panic

  Show description for 4a0d6ef
  mkcp

  committed
  4a0d6ef

• fix: see if CI is flaking with the original tests. probably just need to nolint ignore them

  Show description for 4da92b9
  mkcp

  committed
  4da92b9

• fix: these tests should clean up properly and not error

  Show description for 29c5d08
  mkcp

  committed
  29c5d08

• fix: actually cleaning up the test with RemovalAll seems to cause a panic

  Show description for dfdf78a
  mkcp

  committed
  dfdf78a

• fix: reintroduce the ext_in_cluster test error catches

  Show description for 5a4241e
  mkcp

  committed
  5a4241e

• fix: missed a spot

  Show description for ac3db17
  mkcp

  committed
  ac3db17

• fix: e2e 24 - can we assert that this error exists or do we have to ignore it

  Show description for 3b274f7
  mkcp

  committed
  3b274f7

• fix: address some fixmes before merge

  Show description for a9d6266
  mkcp

  committed
  a9d6266

• fix: does this work now?

  Show description for ccabf6c
  mkcp

  committed
  ccabf6c

• fix: handle and propagate errors in pkg/utils

  Show description for 8a56cd5
  mkcp

  committed
  8a56cd5

• fix: propagate any errors in ColorPrintYAML

  Show description for 5addccc
  mkcp

  committed
  5addccc

• fix: propagate any errors in src/pkg/message

  Show description for 7c04dff
  mkcp

  committed
  7c04dff

• fix: propagate any errors in src/pkg/variables

  Show description for acdb601
  mkcp

  committed
  acdb601

• fix: propagate any errors in src/pkg/layout

  Show description for 803b55e
  mkcp

  committed
  803b55e

• fix: srcfile is already closed and the error handled, no need to defer before loop

  Show description for ffc2d20
  mkcp

  committed
  ffc2d20

Commits on Sep 26, 2024

• fix: ensure errors from deferred resource cleanup are passed back to caller

  Show description for 35cf75e
  mkcp

  committed
  35cf75e

• chore: undo linter rule for CI so we can merge incremental changes

  Show description for 53a175b
  mkcp

  committed
  53a175b

• chore: undo the other linter rule

  Show description for 391296f
  mkcp

  committed
  391296f

• chore: extract test changes to another branch

  Show description for 2c61d4c
  mkcp

  committed
  2c61d4c

• fix: remove nolints for now to make ci happy. we'll have to readd later

  Show description for 423c96a
  mkcp

  committed
  423c96a

• Merge branch 'main' into mkcp/2949-errcheck-linter

  mkcp

  authored
  41265d3

Commits on Sep 30, 2024

• chore: address some review comments

  Show description for d2334bb
  mkcp

  committed
  d2334bb

• chore: fix some bugs in nil returns for errors.Join and address review comments

  Show description for a043273
  mkcp

  committed
  a043273

• review comment

  Show description for 59c3113
  mkcp

  committed
  59c3113

• chore: missed some slogs

  Show description for 7f53091
  mkcp

  committed
  7f53091

• chore: gofmt cmd/tools/helm.go

  Show description for 1602735
  mkcp

  committed
  1602735

• Merge branch 'main' into mkcp/2949-errcheck-linter

  mkcp

  authored
  7d4da41

• chore: mark some todos for lint ignores

  Show description for 91b28ba
  mkcp

  committed
  91b28ba

Commits on Oct 1, 2024

• fix review comments

  Show description for 910027f
  mkcp

  committed
  910027f

• fix: actually store the error values in the deferred cleanup

  Show description for e56681c
  mkcp

  committed
  e56681c

• a/b testing if inline closes not defers fixes windows tests

  Show description for 193254c
  mkcp

  committed
  193254c

• a/b testing... is it really two closes that fixes it?

  Show description for bb4b8b6
  mkcp

  committed
  bb4b8b6

• a/b testing... what about inline only, no defer inside the loop?

  Show description for 6c86974
  mkcp

  committed
  6c86974

• a/b testing... no inline inside loop. defer only. and defer outside of loop

  Show description for ff0df92
  mkcp

  committed
  ff0df92

• fix: ensure we close the file before trying to remove it

  Show description for df0d3b4
  mkcp

  committed
  df0d3b4

• fix: if the file is already closed, don't join to err return

  Show description for 2afa430
  mkcp

  committed
  2afa430

• ignore intentionally blank errs

  Show description for 22b6bf5
  mkcp

  committed
  22b6bf5

• return cluster errors in cmd/package

  Show description for 1a47fb5
  mkcp

  committed
  1a47fb5

• add linter rule for errcheck empty. ignore some dirs

  Show description for 6243854
  mkcp

  committed
  6243854

Commits on Oct 2, 2024

• Merge branch 'main' into mkcp/2949-add-linter

  mkcp

  authored
  025bd87

• remove bigbang linter exception

  Show description for 75a4532
  mkcp

  committed
  75a4532

• remove extra slog import

  Show description for 350df60
  mkcp

  committed
  350df60

• cleanup some more merge cruft

  Show description for c2ff39b
  mkcp

  committed
  c2ff39b

• remove comment and add linter ignore for CI

  Show description for c4b1789
  mkcp

  committed
  c4b1789

• Is this defer cleanup timing out CI?

  Show description for f94e75d
  mkcp

  committed
  f94e75d

• do not error if we fail to find a cluster here

  Show description for e1269a4
  mkcp

  committed
  e1269a4

• fixed this in another branch, snuck thru

  Show description for 74e9c2f
  mkcp

  committed
  74e9c2f

Commits on Oct 3, 2024

• Merge branch 'main' into mkcp/2949-add-linter

  mkcp

  authored
  f346300

• Update src/test/external/ext_out_cluster_test.go

  Show description for 29ffbbf
  

  mkcp

  and

  AustinAbro321

  authored
  29ffbbf