Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add linter (2949) #3053

Merged
merged 61 commits into from
Oct 3, 2024
Merged

feat: add linter (2949) #3053

merged 61 commits into from
Oct 3, 2024

Conversation

mkcp
Copy link
Contributor

@mkcp mkcp commented Oct 1, 2024 •
edited
Loading

Description

This PR completes the work in the other PRs that store and return errors from various empty and ignored returns. It should be merged after #2993 to ensure we don't add the lint rule before it's fulfilled and create a dirty CI state on main.

Related Issue

Fixes #2949
Depends on #2993
Relates to #2953

Checklist before merging

mkcp added 30 commits September 25, 2024 11:00
@mkcp
add errcheck linting
358dd41 
Signed-off-by: Kit Patella <[email protected]>
@mkcp
linter ignore some intentionally unhandled errs
655dd76 
Signed-off-by: Kit Patella <[email protected]>
@mkcp
handle some env var set and unset errors in tests
cce62ce 
Signed-off-by: Kit Patella <[email protected]>
@mkcp
make some notes in cmd/destroy.go for later
ae05ebb 
Signed-off-by: Kit Patella <[email protected]>
@mkcp
direct handle some deferred cleanups to add direct error handling
992aa3c 
Signed-off-by: Kit Patella <[email protected]>
@mkcp
capture errors from cmd/root
81e54f7 
Signed-off-by: Kit Patella <[email protected]>
@mkcp
capture errors on src/config/config.go. checking ci
9b2b2e9 
Signed-off-by: Kit Patella <[email protected]>
@mkcp
fix: ensure we capture and propagate errors in src/internal
a508aa7 
Signed-off-by: Kit Patella <[email protected]>
@mkcp
fix: propagate or log unhandled errors in src/cmd
6f53a29 
Signed-off-by: Kit Patella <[email protected]>
@mkcp
fix: check for or intentionally ignore some dangling errors in tests
4283faf 
Signed-off-by: Kit Patella <[email protected]>
@mkcp
fix: use RemoveAll not remove so it doesnt error every time
cd5fdc7 
Signed-off-by: Kit Patella <[email protected]>
@mkcp
fix: disabling the err catch to see if it's something i changed
9059544 
Signed-off-by: Kit Patella <[email protected]>
@mkcp
fix: should fix the directory not empty panic
4a0d6ef 
Signed-off-by: Kit Patella <[email protected]>
@mkcp
fix: see if CI is flaking with the original tests. probably just need…
4da92b9 
… to nolint ignore them

Signed-off-by: Kit Patella <[email protected]>
@mkcp
fix: these tests should clean up properly and not error
29c5d08 
Signed-off-by: Kit Patella <[email protected]>
@mkcp
fix: actually cleaning up the test with RemovalAll seems to cause a p…
dfdf78a 
…anic

Signed-off-by: Kit Patella <[email protected]>
@mkcp
fix: reintroduce the ext_in_cluster test error catches
5a4241e 
Signed-off-by: Kit Patella <[email protected]>
@mkcp
fix: missed a spot
ac3db17 
Signed-off-by: Kit Patella <[email protected]>
@mkcp
fix: e2e 24 - can we assert that this error exists or do we have to i…
3b274f7 
…gnore it

Signed-off-by: Kit Patella <[email protected]>
@mkcp
fix: address some fixmes before merge
a9d6266 
Signed-off-by: Kit Patella <[email protected]>
@mkcp
fix: does this work now?
ccabf6c 
Signed-off-by: Kit Patella <[email protected]>
@mkcp
fix: handle and propagate errors in pkg/utils
8a56cd5 
Signed-off-by: Kit Patella <[email protected]>
@mkcp
fix: propagate any errors in ColorPrintYAML
5addccc 
Signed-off-by: Kit Patella <[email protected]>
@mkcp
fix: propagate any errors in src/pkg/message
7c04dff 
Signed-off-by: Kit Patella <[email protected]>
@mkcp
fix: propagate any errors in src/pkg/variables
acdb601 
Signed-off-by: Kit Patella <[email protected]>
@mkcp
fix: propagate any errors in src/pkg/layout
803b55e 
Signed-off-by: Kit Patella <[email protected]>
@mkcp
fix: srcfile is already closed and the error handled, no need to defe…
ffc2d20 
…r before loop

Signed-off-by: Kit Patella <[email protected]>
@mkcp
fix: ensure errors from deferred resource cleanup are passed back to …
35cf75e 
…caller

Signed-off-by: Kit Patella <[email protected]>
@mkcp
chore: undo linter rule for CI so we can merge incremental changes
53a175b 
Signed-off-by: Kit Patella <[email protected]>
@mkcp
chore: undo the other linter rule
391296f 
Signed-off-by: Kit Patella <[email protected]>
mkcp added 2 commits October 2, 2024 11:40
@codecov Codecov
Copy link

codecov bot commented Oct 2, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/cmd/package.go 0.00% 9 Missing ⚠️
src/pkg/utils/cosign.go 0.00% 3 Missing ⚠️
Files with missing lines Coverage Δ
src/pkg/utils/cosign.go 0.00% <0.00%> (ø)
src/cmd/package.go 0.00% <0.00%> (ø)

@mkcp mkcp added this to the v0.40.0 milestone Oct 2, 2024
schristoff
schristoff previously approved these changes Oct 3, 2024
View reviewed changes
@mkcp mkcp requested a review from schristoff October 3, 2024 15:35
@mkcp mkcp enabled auto-merge October 3, 2024 15:48
AustinAbro321
AustinAbro321 previously approved these changes Oct 3, 2024
View reviewed changes
@mkcp mkcp added this pull request to the merge queue Oct 3, 2024
@AustinAbro321 AustinAbro321 removed this pull request from the merge queue due to a manual request Oct 3, 2024
@mkcp mkcp enabled auto-merge October 3, 2024 18:05
@mkcp mkcp added this pull request to the merge queue Oct 3, 2024
Merged via the queue into main with commit e1a99f6 Oct 3, 2024
26 checks passed
@mkcp mkcp deleted the mkcp/2949-add-linter branch October 3, 2024 18:30
mjnagel pushed a commit to mjnagel/zarf that referenced this pull request Oct 21, 2024
@mkcp @AustinAbro321 @mjnagel
feat: add linter (2949) (zarf-dev#3053)
e8b6c9f 
Signed-off-by: Kit Patella <[email protected]>
Co-authored-by: Austin Abro <[email protected]>
Signed-off-by: Micah Nagel <[email protected]>
ittacco pushed a commit to ittacco/zarf that referenced this pull request Nov 9, 2024
@mkcp @AustinAbro321 @ittacco
feat: add linter (2949) (zarf-dev#3053)
be3a732 
Signed-off-by: Kit Patella <[email protected]>
Co-authored-by: Austin Abro <[email protected]>
Signed-off-by: ittacco <[email protected]>
Jneville0815 pushed a commit to radiusmethod/zarf that referenced this pull request Dec 12, 2024
@mkcp @AustinAbro321 @Jneville0815
feat: add linter (2949) (zarf-dev#3053)
8007197 
Signed-off-by: Kit Patella <[email protected]>
Co-authored-by: Austin Abro <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AustinAbro321 AustinAbro321 AustinAbro321 approved these changes

@schristoff schristoff Awaiting requested review from schristoff

Assignees

@mkcp mkcp

Labels
ready-for-review
Projects
None yet
Milestone
v0.40.0
Development

Successfully merging this pull request may close these issues.

Enable linting ignored
3 participants
@mkcp @schristoff @AustinAbro321