chore: directly handle ignored errs and nolint intentionally ignored errs

[mkcp]

Description

This PR relies on enabling additional errcheck rules on golangci-lint and revive to find errors that we've failed to handle or propagate. The most common cases are defers, which we handle by joining them with a err named return (a bit too much magic imo, but is the most airtight in case of a panic). Ideally we handle a specific error that wasn't passed up, but sometimes we have to change the function signature. Lastly, there's times where propagating the error isn't viable or useful and we'll have to log out.

Unfortunately the linter will flag when there's unused nolint checks, so we can't mark intentionally ignored errors with //nolint:errcheck until the actual PR that introduces the linter checks into main.

Rules changes are:

diff --git a/.golangci.yaml b/.golangci.yaml
index 6423df77..18b3f0f1 100644
--- a/.golangci.yaml
+++ b/.golangci.yaml
@@ -59,6 +59,7 @@ linters-settings:
   testifylint:
     enable-all: true
   errcheck:
+    check-blank: true
     check-type-assertions: true
     exclude-functions:
       - (*github.com/spf13/cobra.Command).Help
@@ -68,6 +69,7 @@ linters-settings:
 issues:
   # Revive rules that are disabled by default.
   include:
+    - EXC0001
     - EXC0012
     - EXC0013
     - EXC0014

Related Issue

Blocks #3053
Relates to #2953

Checklist before merging

• Test, docs, adr added or updated as needed
• Contributor Guide Steps followed

[netlify]

✅ Deploy Preview for zarf-docs canceled.

Name	Link
🔨 Latest commit	1c69af4
🔍 Latest deploy log	https://app.netlify.com/sites/zarf-docs/deploys/66fd84d1cee7220008194d33

[codecov]

Codecov Report

Attention: Patch coverage is 15.81028% with 213 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/cmd/package.go	0.00%	31 Missing ⚠️
src/cmd/dev.go	0.00%	19 Missing ⚠️
src/cmd/initialize.go	0.00%	15 Missing ⚠️
src/pkg/message/progress.go	0.00%	10 Missing ⚠️
src/pkg/utils/cosign.go	0.00%	9 Missing ⚠️
src/pkg/zoci/push.go	0.00%	9 Missing ⚠️
src/cmd/tools/zarf.go	0.00%	7 Missing ⚠️
src/config/config.go	0.00%	7 Missing ⚠️
src/pkg/layout/package.go	12.50%	6 Missing and 1 partial ⚠️
src/pkg/message/spinner.go	0.00%	7 Missing ⚠️
... and 23 more

Files with missing lines	Coverage Δ
src/pkg/utils/network.go	66.66% <100.00%> (+3.50%)	⬆️
src/pkg/variables/templates.go	81.53% <77.77%> (-1.52%)	⬇️
src/cmd/root.go	0.00% <0.00%> (ø)
src/cmd/tools/helm.go	0.00% <0.00%> (ø)
src/pkg/layout/component.go	0.00% <0.00%> (ø)
src/pkg/packager/creator/normal.go	6.18% <0.00%> (-1.89%)	⬇️
src/pkg/packager/inspect.go	0.00% <0.00%> (ø)
src/pkg/packager/interactive.go	0.00% <0.00%> (ø)
src/pkg/packager/publish.go	0.00% <0.00%> (ø)
src/pkg/utils/auth.go	74.00% <76.92%> (+0.08%)	⬆️
... and 24 more

... and 12 files with indirect coverage changes

[AustinAbro321]

I believe we want to check the err here within the defer block